Support snapshotting SwiftUI views #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashfurrow
approved these changes
Sep 10, 2024
|
(The Danger failure isn't due to your change, it's a permissions issue. I'm thinking of removing it entirely to prevent me from responding to every PR from a fork with "the failure isn't your fault!") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocols can't be extended to conform to other protocols, sadly.
So this duplicates the haveValidSnapshot/recordSnapshot matchers with ones that take in a SwiftUI View. Then, inside of that, the SwiftUI View is converted to a Snapshotable, and we delegate to the appropriate matcher for snapshotable.
Fixes #252