Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new block manager when writing files #619

Closed
drdavella opened this issue Nov 27, 2018 · 1 comment
Closed

Create a new block manager when writing files #619

drdavella opened this issue Nov 27, 2018 · 1 comment
Assignees

Comments

@drdavella
Copy link
Contributor

drdavella commented Nov 27, 2018

Currently the same block manager is used for all writes of the same AsdfFile object, and it retains state between calls to write_to. This is not good because it leads to confusing and sometimes erroneous behavior with respect to the storage type of certain arrays (see #599 and #618 for one particular example).

When creating an AsdfFile object with the intent to write a new file, there is no need to create a block manager until actually calling write_to. This should help resolve ambiguities without introducing any other user-visible effects.

@drdavella drdavella added this to the v2.4.0 milestone Nov 27, 2018
@drdavella drdavella self-assigned this Nov 27, 2018
@asdf-format asdf-format deleted a comment from stscijgbot Aug 6, 2019
@nden nden modified the milestones: v2.4.0, 2.6, 2.7 Nov 18, 2019
@eslavich eslavich removed this from the 2.7.0 milestone Jul 16, 2020
@braingram
Copy link
Contributor

#1537 largely rewrote block management. Read and written blocks are now separated. Write blocks are not created until writing and are not shared across writes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants