From eaf107ecd498b741859e8e4f1f2c8ea63df7d6a6 Mon Sep 17 00:00:00 2001 From: zacharyburnett Date: Fri, 16 Aug 2024 12:19:26 -0400 Subject: [PATCH 1/6] add towncrier configuration --- CHANGES.rst | 5 ----- pyproject.toml | 12 ++++++++++++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index 2a441728c..5ada9ff65 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,8 +1,3 @@ -3.5.0 (unreleased) ------------------- - -- - 3.4.0 (2024-08-04) ------------------ diff --git a/pyproject.toml b/pyproject.toml index dc347ab0d..74b3106e9 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -193,3 +193,15 @@ skip="*.pdf,*.asdf,.tox,asdf/_extern,asdf/_jsonschema,build,./tags,.git,docs/_bu ignore-words-list=""" fo,afile, """ + +[tool.towncrier] +filename = "CHANGES.rst" +directory = "changes" +package = "asdf" +title_format = "{version} ({project_date})" + +[tool.changelog-bot.towncrier_changelog] +enabled = true +verify_pr_number = true +changelog_skip_label = "no-changelog-entry-needed" +changelog_noop_label = "skip-changelog-checks" From 660612cb891ff081cc81097cb0c4750390b0084d Mon Sep 17 00:00:00 2001 From: zacharyburnett Date: Mon, 19 Aug 2024 12:26:07 -0400 Subject: [PATCH 2/6] use towncrier --- .github/pull_request_template.md | 4 ++-- .github/workflows/changelog.yml | 30 +++++++++++++++++------------- CONTRIBUTING.rst | 10 ++++++++++ changes/.gitkeep | 0 pyproject.toml | 7 +------ 5 files changed, 30 insertions(+), 21 deletions(-) create mode 100644 changes/.gitkeep diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 56a248f3e..32be9e07f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -29,6 +29,6 @@ If this PR fixes an issue, please add closing keywords (eg 'fixes #XXX') - [ ] pre-commit checks ran successfully - [ ] tests ran successfully -- [ ] for a public change, a changelog entry was added -- [ ] for a public change, documentation was updated +- [ ] for a public change, added news fragment (`changes/..rst`) +- [ ] for a public change, updated documentation - [ ] for any new features, unit tests were added diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 9e949e086..9a5c3859d 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -1,26 +1,30 @@ -name: Changelog +name: changelog on: pull_request: - types: [labeled, unlabeled, opened, synchronize, reopened] + types: + - labeled + - unlabeled + - opened + - synchronize + - reopened -# Only cancel in-progress jobs or runs for the current workflow -# This cancels the already triggered workflows for a specific PR without canceling -# other instances of this workflow (other PRs, scheduled triggers, etc) when something -# within that PR re-triggers this CI concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true jobs: - changelog: - name: Confirm changelog entry + check: + if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-changelog-entry-needed') }} runs-on: ubuntu-latest steps: - - name: Checkout code - uses: actions/checkout@v4 + - uses: actions/setup-python@v5 + with: + python-version: 3 + - uses: actions/checkout@v4 with: fetch-depth: 0 - - name: Grep for PR number in CHANGES.rst - run: grep -P '\[[^\]]*#${{github.event.number}}[,\]]' CHANGES.rst - if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-changelog-entry-needed') }} + - run: pip install . + - run: pip install towncrier + - run: towncrier build + - run: grep -P '\[[^\]]*#${{ github.event.number }}[,\]]' CHANGES.rst diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 5a9c5022b..c623fc53d 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -53,3 +53,13 @@ to the maintainers, who are glad to assist you. a maintainer, you can comment ``@meeseeksdev backport to `` on a pull request to manually trigger a backport. Moreover, when merging a "backport" pull request, please use the "Rebase and merge" option. + +.. note:: + When making a public change, add a news fragment to ``changes/`` with the + filename ``..rst``. The change types are as follows: + + - ``feature``: new feature + - ``bugfix``: bug fix + - ``doc``: documentation change + - ``removal``: deprecation or removal of public API + - ``misc``: not of interest to users diff --git a/changes/.gitkeep b/changes/.gitkeep new file mode 100644 index 000000000..e69de29bb diff --git a/pyproject.toml b/pyproject.toml index 74b3106e9..092b51dc0 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -199,9 +199,4 @@ filename = "CHANGES.rst" directory = "changes" package = "asdf" title_format = "{version} ({project_date})" - -[tool.changelog-bot.towncrier_changelog] -enabled = true -verify_pr_number = true -changelog_skip_label = "no-changelog-entry-needed" -changelog_noop_label = "skip-changelog-checks" +ignore = [".gitkeep"] From ddcf4c77893850862bbb67c0746b63b51376b6c2 Mon Sep 17 00:00:00 2001 From: zacharyburnett Date: Mon, 19 Aug 2024 12:27:30 -0400 Subject: [PATCH 3/6] run towncrier in readthedocs job --- .readthedocs.yaml | 2 ++ docs/rtd_environment.yaml | 1 + 2 files changed, 3 insertions(+) diff --git a/.readthedocs.yaml b/.readthedocs.yaml index 80c8c01cf..d28775c1c 100644 --- a/.readthedocs.yaml +++ b/.readthedocs.yaml @@ -13,6 +13,8 @@ build: - git fetch --all --tags || true pre_install: - git update-index --assume-unchanged docs/rtd_environment.yaml docs/conf.py + post_install: + - towncrier build conda: environment: docs/rtd_environment.yaml diff --git a/docs/rtd_environment.yaml b/docs/rtd_environment.yaml index 161fef38a..6e6bfa6a3 100644 --- a/docs/rtd_environment.yaml +++ b/docs/rtd_environment.yaml @@ -7,3 +7,4 @@ dependencies: - pip - graphviz - sphinx_rtd_theme>1.2.0 + - towncrier From 793a8307be327d35659097c5a22b39f3611ee60b Mon Sep 17 00:00:00 2001 From: zacharyburnett Date: Mon, 19 Aug 2024 12:45:24 -0400 Subject: [PATCH 4/6] change header level --- CHANGES.rst | 130 ++++++++++++++++++++++++++-------------------------- 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index 5ada9ff65..8629f60aa 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,5 +1,5 @@ 3.4.0 (2024-08-04) ------------------- +================== - Fix issue where roundtripping a masked array with no masked values removes the mask [#1803] @@ -14,7 +14,7 @@ - Bumped minimal requirement on ``attrs`` from ``20.1.0`` to ``22.2.0`` [#1815] 3.3.0 (2024-07-12) ------------------- +================== - Fix ``__asdf_traverse__`` for non-tagged objects [#1739] @@ -53,7 +53,7 @@ - Deprecate ``copy_arrays`` in favor of ``memmap`` [#1797] 3.2.0 (2024-04-05) ------------------- +================== - Deprecate ``AsdfFile.version_map`` [#1745] @@ -65,7 +65,7 @@ 3.1.0 (2024-02-27) ------------------- +================== The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -113,7 +113,7 @@ The ASDF Standard is at v1.6.0 3.0.1 (2023-10-30) ------------------- +================== The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -125,7 +125,7 @@ The ASDF Standard is at v1.6.0 3.0.0 (2023-10-16) ------------------- +================== The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -157,7 +157,7 @@ The ASDF Standard is at v1.6.0 for ``asdftool diff`` comparisons [#1652] 2.15.2 (2023-09-29) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -165,7 +165,7 @@ The ASDF Standard is at v1.6.0 - Add support for python 3.12 [#1641] 2.15.1 (2023-08-07) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -178,7 +178,7 @@ The ASDF Standard is at v1.6.0 - Drop jsonschema as a dependency [#1614] 2.15.0 (2023-03-28) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -217,7 +217,7 @@ The ASDF Standard is at v1.6.0 - rename master branch to main [#1479] 2.14.4 (2022-03-17) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -225,7 +225,7 @@ The ASDF Standard is at v1.6.0 - require jsonschema<4.18 [#1487] 2.14.3 (2022-12-15) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -235,7 +235,7 @@ The ASDF Standard is at v1.6.0 - Bump asdf-transform-schemas version [#1278] 2.14.2 (2022-12-05) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -243,7 +243,7 @@ The ASDF Standard is at v1.6.0 - Fix issue #1256, where ``enum`` could not be used on tagged objects. [#1257] 2.14.1 (2022-11-23) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -252,7 +252,7 @@ The ASDF Standard is at v1.6.0 - Add ndarray-1.1.0 and integer-1.1.0 support [#1250] 2.14.0 (2022-11-22) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -274,7 +274,7 @@ The ASDF Standard is at v1.6.0 - Fix issue #1232 where array data was duplicated during resaving of a fits file [#1234] 2.13.0 (2022-08-19) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -283,7 +283,7 @@ The ASDF Standard is at v1.6.0 method. [#1167] 2.12.1 (2022-08-17) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -294,7 +294,7 @@ The ASDF Standard is at v1.6.0 - Pin ``jsonschema`` to below ``4.10.0``. [#1171] 2.12.0 (2022-06-06) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -304,12 +304,12 @@ The ASDF Standard is at v1.6.0 - Add ability to set asdf-standard version for schema example items. [#1143] 2.11.2 (2022-08-17) -------------------- +==================- - Backport ``jsonschema`` pin to strictly less than 4.10.1. [#1175] 2.11.1 (2022-04-15) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -317,7 +317,7 @@ The ASDF Standard is at v1.6.0 - Update minimum astropy version to 5.0.4. [#1133] 2.11.0 (2022-03-15) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -325,7 +325,7 @@ The ASDF Standard is at v1.6.0 - Update minimum jsonschema version to 4.0.1. [#1105] 2.10.1 (2022-03-02) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -335,7 +335,7 @@ The ASDF Standard is at v1.6.0 - Fix small bug with handling multiple schema uris per tag. [#1095] 2.10.0 (2022-02-17) -------------------- +==================- The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -343,7 +343,7 @@ The ASDF Standard is at v1.6.0 - Replace asdf-standard submodule with pypi package. [#1079] 2.9.2 (2022-02-07) ------------------- +================== The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -353,7 +353,7 @@ The ASDF Standard is at v1.6.0 - Fix bug in pytest plugin when schemas are not in a directory named "schemas". [#1076] 2.9.1 (2022-02-03) ------------------- +================== The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -361,7 +361,7 @@ The ASDF Standard is at v1.6.0 - Fix typo in testing module ``__init__.py`` name. [#1071] 2.9.0 (2022-02-02) ------------------- +================== The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -389,7 +389,7 @@ The ASDF Standard is at v1.6.0 helpers previously available in ``asdf.tests.helpers``. [#1067] 2.8.3 (2021-12-13) ------------------- +================== The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -397,7 +397,7 @@ The ASDF Standard is at v1.6.0 - Fix more use of 'python' where 'python3' is intended. [#1033] 2.8.2 (2021-12-06) ------------------- +================== The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -415,13 +415,13 @@ The ASDF Standard is at v1.6.0 instances. [#1031] 2.8.1 (2021-06-09) ------------------- +================== - Fix bug in block manager when a new block is added to an existing file without a block index. [#1000] 2.8.0 (2021-05-12) ------------------- +================== The ASDF Standard is at v1.6.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -501,7 +501,7 @@ The ASDF Standard is at v1.6.0 - Update asdf-standard to 1.6.0 tag. [#993] 2.7.5 (2021-06-09) ------------------- +================== The ASDF Standard is at v1.5.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -513,7 +513,7 @@ The ASDF Standard is at v1.5.0 file without a block index. [#1000] 2.7.4 (2021-04-30) ------------------- +================== The ASDF Standard is at v1.5.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -529,7 +529,7 @@ The ASDF Standard is at v1.5.0 - Prevent astropy warnings in tests when opening known bad files. [#977] 2.7.3 (2021-02-25) ------------------- +================== The ASDF Standard is at v1.5.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -541,7 +541,7 @@ The ASDF Standard is at v1.5.0 FITS arrays. [#930] 2.7.2 (2021-01-15) ------------------- +================== The ASDF Standard is at v1.5.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -551,7 +551,7 @@ The ASDF Standard is at v1.5.0 - Fix bug when decompressing arrays with numpy 1.20. [#901, #909] 2.7.1 (2020-08-18) ------------------- +================== The ASDF Standard is at v1.5.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -560,7 +560,7 @@ The ASDF Standard is at v1.5.0 ``AsdfFile`` is closed. [#869] 2.7.0 (2020-07-23) ------------------- +================== The ASDF Standard is at v1.5.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -623,7 +623,7 @@ The ASDF Standard is at v1.5.0 properties. [#832] 2.6.0 (2020-04-22) ------------------- +================== The ASDF Standard is at v1.5.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -659,7 +659,7 @@ The ASDF Standard is at v1.5.0 to handle internal references and reference cycles. [#781] 2.5.2 (2020-02-28) ------------------- +================== The ASDF Standard is at v1.4.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -679,7 +679,7 @@ The ASDF Standard is at v1.4.0 - Simplify example in README.rst [#763] 2.5.1 (2020-01-07) ------------------- +================== The ASDF Standard is at v1.4.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -688,7 +688,7 @@ The ASDF Standard is at v1.4.0 an installed asdf package. [#732] 2.5.0 (2019-12-23) ------------------- +================== The ASDF Standard is at v1.4.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -705,7 +705,7 @@ The ASDF Standard is at v1.4.0 - Fix bug causing segfault after update of a memory-mapped file. [#716] 2.4.2 (2019-08-29) ------------------- +================== The ASDF Standard is at v1.3.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -714,7 +714,7 @@ The ASDF Standard is at v1.3.0 around a Deprecation warning. [#700] 2.4.1 (2019-08-27) ------------------- +================== The ASDF Standard is at v1.3.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -736,7 +736,7 @@ The ASDF Standard is at v1.3.0 property. [#673] 2.3.3 (2019-04-02) ------------------- +================== The ASDF Standard is at v1.3.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -754,7 +754,7 @@ The ASDF Standard is at v1.3.0 - Allow use of ``pathlib.Path`` objects for ``custom_schema`` option. [#663] 2.3.2 (2019-02-19) ------------------- +================== The ASDF Standard is at v1.3.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -763,7 +763,7 @@ The ASDF Standard is at v1.3.0 found in file. [#641] 2.3.1 (2018-12-20) ------------------- +================== The ASDF Standard is at v1.3.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -780,7 +780,7 @@ The ASDF Standard is at v1.3.0 visible. [#633] 2.3.0 (2018-11-28) ------------------- +================== The ASDF Standard is at v1.3.0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -802,13 +802,13 @@ The ASDF Standard is at v1.3.0 - Update ASDF Standard submodule to version 1.3.0. 2.2.1 (2018-11-15) ------------------- +================== - Fix an issue with the README that caused sporadic installation failures and also prevented the long description from being rendered on pypi. [#607] 2.2.0 (2018-11-14) ------------------- +================== - Add new parameter ``lazy_load`` to ``AsdfFile.open``. It is ``True`` by default and preserves the default behavior. ``False`` detaches the @@ -828,14 +828,14 @@ The ASDF Standard is at v1.3.0 handle is readonly. [#579] 2.1.2 (2018-11-13) ------------------- +================== - Make sure that all types corresponding to core tags are added to the type index before any others. This fixes a bug that was related to the way that subclass tags were overwritten by external extensions. [#598] 2.1.1 (2018-11-01) ------------------- +================== - Make sure extension metadata is written even when constructing the ASDF tree on-the-fly. [#549] @@ -854,7 +854,7 @@ The ASDF Standard is at v1.3.0 is converted to basic Python data structures. [#571] 2.1.0 (2018-09-25) ------------------- +================== - Add API function for retrieving history entries. [#501] @@ -870,7 +870,7 @@ The ASDF Standard is at v1.3.0 - Add top-level ``keys`` method to ``AsdfFile`` to access tree keys. [#545] 2.0.3 (2018-09-06) ------------------- +================== - Update asdf-standard to reflect more stringent (and, consequently, more correct) requirements on the formatting of complex numbers. [#526] @@ -881,7 +881,7 @@ The ASDF Standard is at v1.3.0 [#539] 2.0.2 (2018-07-27) ------------------- +================== - Allow serialization of broadcasted ``numpy`` arrays. [#507] @@ -895,12 +895,12 @@ The ASDF Standard is at v1.3.0 schema file. [#522] 2.0.1 (2018-05-08) ------------------- +================== - Allow test suite to run even when package is not installed. [#502] 2.0.0 (2018-04-19) ------------------- +================== - Astropy-specific tags have moved to Astropy core package. [#359] @@ -959,14 +959,14 @@ The ASDF Standard is at v1.3.0 ``fits``. Bump top-level ASDF schema version to v1.1.0. [#444] 1.3.3 (2018-03-01) ------------------- +================== - Update test infrastructure to rely on new Astropy v3.0 plugins. [#461] - Disable use of 2to3. This was causing test failures on Debian builds. [#463] 1.3.2 (2018-02-22) ------------------- +================== - Updates to allow this version of ASDF to be compatible with Astropy v3.0. [#450] @@ -975,7 +975,7 @@ The ASDF Standard is at v1.3.0 testing infrastructure. [#458] 1.3.1 (2017-11-02) ------------------- +================== - Relax requirement on ``semantic_version`` version to 2.3.1. [#361] @@ -987,7 +987,7 @@ The ASDF Standard is at v1.3.0 [#371] 1.3.0 (2017-10-24) ------------------- +================== - Fixed a bug in reading data from an "http:" url. [#231] @@ -1058,13 +1058,13 @@ The ASDF Standard is at v1.3.0 ``__setitem__``. [#352] 1.2.1 (2016-11-07) ------------------- +================== - Make asdf conditionally dependent on the version of astropy to allow running it with older versions of astropy. [#228] 1.2.0 (2016-10-04) ------------------- +================== - Added Tabular model. [#214] @@ -1075,18 +1075,18 @@ The ASDF Standard is at v1.3.0 - Fixed version error message [#224] 1.0.5 (2016-06-28) ------------------- +================== - Fixed a memory leak when reading wcs that grew memory to over 10 Gb. [#200] 1.0.4 (2016-05-25) ------------------- +================== - Added wrapper class for astropy.core.Time, TaggedTime. [#198] 1.0.2 (2016-02-29) ------------------- +================== - Renamed package to ASDF. [#190] @@ -1094,7 +1094,7 @@ The ASDF Standard is at v1.3.0 1.0.1 (2016-01-08) ------------------- +================== - Fixed installation from the source tarball on Python 3. [#187] @@ -1106,6 +1106,6 @@ The ASDF Standard is at v1.3.0 1.0.0 (2015-09-18) ------------------- +================== - Initial release. From bc4fa67aeb370128a5c427edb5aa877fc24356d6 Mon Sep 17 00:00:00 2001 From: zacharyburnett Date: Mon, 19 Aug 2024 12:49:14 -0400 Subject: [PATCH 5/6] use towncrier check and towncrier build --draft --- .github/workflows/changelog.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 9a5c3859d..f8c82e736 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -26,5 +26,5 @@ jobs: fetch-depth: 0 - run: pip install . - run: pip install towncrier - - run: towncrier build - - run: grep -P '\[[^\]]*#${{ github.event.number }}[,\]]' CHANGES.rst + - run: towncrier check + - run: towncrier build --draft | grep -P '\[[^\]]*#${{ github.event.number }}[,\]]' From b8e791cdf8aa410312b5328ead277d88e93a0010 Mon Sep 17 00:00:00 2001 From: zacharyburnett Date: Mon, 19 Aug 2024 14:14:02 -0400 Subject: [PATCH 6/6] add links to issue numbers in changelog --- .github/workflows/changelog.yml | 2 +- pyproject.toml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index f8c82e736..7beb997bf 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -27,4 +27,4 @@ jobs: - run: pip install . - run: pip install towncrier - run: towncrier check - - run: towncrier build --draft | grep -P '\[[^\]]*#${{ github.event.number }}[,\]]' + - run: towncrier build --draft | grep -P '[\(\[][^\)\]]*#${{ github.event.number }}[,\)\]]' diff --git a/pyproject.toml b/pyproject.toml index 092b51dc0..2d1ca65c7 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -200,3 +200,5 @@ directory = "changes" package = "asdf" title_format = "{version} ({project_date})" ignore = [".gitkeep"] +wrap = true +issue_format = "`#{issue} `_"