Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop subclass_metadata from the standard #246

Open
perrygreenfield opened this issue Jun 19, 2020 · 1 comment
Open

Drop subclass_metadata from the standard #246

perrygreenfield opened this issue Jun 19, 2020 · 1 comment
Milestone

Comments

@perrygreenfield
Copy link
Contributor

This is an experimental feature that sought to make serialization of subclasses more convenient by reusing the superclass's schema, with some additional metadata appended to inform the library of which subclass to instantiate. This feature has some drawbacks. For one, the name of a class or subclass is an implementation detail that is meaningless to other ASDF implementations. Another drawback is that by using a generic schema for multiple subclasses, we are not able to validate as strictly as we could with separate schemas – for example, if subclass A requires property "foo", but subclass B does not, we can't make the property required because both objects must validate against the same schema.

These drawbacks may be reason enough to remove subclass_metadata from the standard.

@nden
Copy link
Contributor

nden commented Sep 13, 2020

Is this done now? Can we close the ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants