Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added German translation strings and language parameter (Resolves #787) #788

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

r0ckarong
Copy link
Contributor

IMPORTANT: Please do not create a pull request without creating an issue first.

Discussion in #787

package.nls.json Outdated Show resolved Hide resolved
package.nls.json Outdated Show resolved Hide resolved
Copy link
Member

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not qualified to review this pull request 😅
@ahus1 Would you be kind enough to review it?

@ggrossetie ggrossetie requested a review from ahus1 September 18, 2023 15:03
@r0ckarong r0ckarong marked this pull request as ready for review September 19, 2023 07:19
@ggrossetie
Copy link
Member

I will move forward and merge it. We can always improve translations (at a later stage) with user feedback.

@ggrossetie ggrossetie merged commit 91ae317 into asciidoctor:master Oct 12, 2023
1 check passed
@r0ckarong r0ckarong deleted the translate-de branch October 12, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants