Add mypy as a dev dependency #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robberwick
force-pushed
the
mypy
branch
2 times, most recently
from
ebac630 to
d81d345
Compare
robberwick
force-pushed
the
mypy
branch
3 times, most recently
from
11d115e to
8309647
Compare
Handle the case that `USBBackend.find_blinksticks()` returns `None`
Neither the win32 or unix USB wrapper packages provide type hints or stubs, so just ignore the mypy errors
we're deprecating the use of color_format, so we set the default value to None in order to test whether it is set/truthy. So, update the type hint to allow None as a type.
type hint the `color_funcs` dict correctly, so that mypy doesn't get confused
set_color expects ints for the r,g,b channel values, so cast gradient channel values to ints before calling
mypy gets sad that value is ever treated as a string, but we need to keep that graceful fallback in there just in case. So just shush mypy
Explicit is better than implicit.
In the event that we can't match the supplied hex value using the RE, raise a ValueError. Otherwise we risk attempting to access the `groups()` method of `None`
When doing `find_by_serial`, default the `serial` param to an empty string, not None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new GitHub Actions workflow for running Mypy type checks and updates the development dependencies to include Mypy. The most important changes include the addition of the Mypy workflow configuration file and the update to the development dependencies in
pyproject.toml.Continuous Integration:
.github/workflows/mypy.yml: Added a new workflow configuration file to run Mypy type checks on push and pull request events. This workflow sets up Python, installs dependencies, and runs Mypy on thesrcandtestsdirectories.Development Dependencies:
pyproject.toml: Updated the[project.optional-dependencies]section to includemypyin thedevdependencies.