Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Inferno, there is a name conflict with _unmounted #157

Open
amadt opened this issue Mar 8, 2017 · 0 comments
Open

Using Inferno, there is a name conflict with _unmounted #157

amadt opened this issue Mar 8, 2017 · 0 comments

Comments

@amadt
Copy link

amadt commented Mar 8, 2017

In compose.js we have

     componentWillUnmount() {
        this._unmounted = true;
        this._unsubscribe();
      }

Inferno actually is using the variable _unmounted in their code as well, and it's causing conflicts. What are the thoughts on trying to use a different scheme on _unmounted to make sure there isn't conflicts. Something like this._compose__unmounted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant