Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No thumnails are shown on iOS7 #19

Open
drd27 opened this issue Jun 30, 2013 · 22 comments
Open

No thumnails are shown on iOS7 #19

drd27 opened this issue Jun 30, 2013 · 22 comments

Comments

@drd27
Copy link

drd27 commented Jun 30, 2013

When building your demo implementation - either using Xcode 4.6.x SDK 6.1 or Xcode 5 SDK 7 - and deploying to a development device running iOS7, no thumbnails are shown -> nothing can be picked.

@mokten
Copy link

mokten commented Jul 15, 2013

Take a look at a working fix: https://github.com/mokten/AGImagePickerController

I removed most of the synchronized cause I thought not needed.

@drd27
Copy link
Author

drd27 commented Jul 15, 2013

Hi
Thanks for looking into that. Will take a look when I return from holiday next week

On 15 jul. 2013, at 13:15, "Mokten" [email protected] wrote:

Take a look at a working fix: https://github.com/mokten/AGImagePickerController

I removed most of the synchronized cause I thought not needed.


Reply to this email directly or view it on GitHub.

@drd27
Copy link
Author

drd27 commented Jul 19, 2013

Hi, that works perfectly.
Thanks!

On 15 Jul 2013, at 13:15 , Mokten [email protected] wrote:

Take a look at a working fix: https://github.com/mokten/AGImagePickerController

I removed most of the synchronized cause I thought not needed.


Reply to this email directly or view it on GitHub.

@VeeYarr
Copy link

VeeYarr commented Jul 26, 2013

Hi - thanks for this, the iOS7 fix brings the thumbnails back - however, it adds an extra blank one after the real thumbnails, if you select this one when choosing some assets, it will obviously result in a crash as it's not a real image... Tried to find the cause myself but came up empty handed....

See attached image for illustration....

screen shot 2013-07-25 at 8 27 15 pm

@usman-whizpool
Copy link

Hi. thanks for the iOS 7 fixes. I also faced same problem stated by StayHungryApps above.

@VeeYarr
Copy link

VeeYarr commented Aug 4, 2013

Same problem with iOS 7 beta 4 - anyone have any suggestions for fixing the "ghost" thumbnail?

@VeeYarr
Copy link

VeeYarr commented Aug 8, 2013

Still an issue with iOS 7 beta 5, pretty sure they are close to a GM now, are we likely to get this fixed? Mokten was so close to having nailed this....

@zoelounge
Copy link

Hello, thank for your works about ios7 fix but don't show toolbar for "select-all" or "deselect-all".

I test any solution but i don't found fix for it.

Can you help me please?

@VeeYarr
Copy link

VeeYarr commented Aug 19, 2013

Looks like we're not going to get this resolved for iOS 7 which is probably less than a month away now - both the ghost thumbnail and the missing select/deselect all issues remain....

Anyone know of any other similar components that can replace this and drop in instead?

@arturgrigor
Copy link
Owner

I'll fix that, but only after the next beta is released.

@VeeYarr
Copy link

VeeYarr commented Aug 19, 2013

Thanks! I think the GM must be close, only issues I'm seeing now in latest beta are some funky rotation problems....

@capitangolo
Copy link

I know that the right thing is to wait for official fix, but I needed this working for testing before next release.

I Applied mokten fix, and avoided the ghost cell adding on AGIPCAssetsController.m line 268:

        // iOS 7 returns a nil result at the end.
        if (!result) return;

https://github.com/mokten/AGImagePickerController/blob/bb4213aaae77867efe6829411d33fbd7b9d212bf/AGImagePickerController/AGIPCAssetsController.m#L268

For some reason 'enumerateAssetsUsingBlock:' is passing a nil result at the end with a NSIntegerMax value for index.

Not sure if this will still be valid for next release, but I hope it helps.

@VeeYarr
Copy link

VeeYarr commented Sep 7, 2013

capitangolo - your fix works great - thanks very much!!

@Huan-FENG
Copy link

Thanks so much for your fix, capitangolo, but the missing of tool bar is still remained with ios 7 beta 6. Is there any advice on how to fix it ?

@Huan-FENG
Copy link

Actually, there's no toolbar with ios 6.0 either.

@nori0620
Copy link

Hi.
I created the fix that avoiding the "missing of tool bar" and "ghost thumbnail".
( The diff is just few lines from Release 2.0.1. )
nori0620@decb762

It looks work fine. But I'm not sure if this fix is proper.
So in non-emergency case, maybe you should waiting for official fix.

@Huan-FENG
Copy link

thanks so much. I'll try that when I'm back from holiday. ^^_

发自我的 iPhone

在 2013-9-13,19:29,Norihiro Sakamoto [email protected] 写道:

Hi.
I fixed that avoiding the "missing of tool bar" and "ghost thumbnail".
( The diff is just few lines from Release 2.0.1. )
nori0620/AGImagePickerController@decb762

It looks work fine. But I'm not sure if this fix is proper.
So in non-emergency case, maybe you should waiting for official fix.


Reply to this email directly or view it on GitHub.

@Huan-FENG
Copy link

thank you so much!
it works fine!

在 2013-9-13,下午7:29, Norihiro Sakamoto 写道:

Hi.
I fixed that avoiding the "missing of tool bar" and "ghost thumbnail".
( The diff is just few lines from Release 2.0.1. )
nori0620/AGImagePickerController@decb762

It looks work fine. But I'm not sure if this fix is proper.
So in non-emergency case, maybe you should waiting for official fix.


Reply to this email directly or view it on GitHub.

@uunc
Copy link

uunc commented Sep 22, 2013

No thumnails are shown on iOS7!!!!! please fix it and support an release, thx ~

@carterminearIMT
Copy link

nori's fix works alright but it will no longer remember how many where selected at the top (4/10) it starts over at 0 even if pictures are selected. Any idea how to fix this?

@yanzhiwei147
Copy link

hi, thank for you fix the bug of ios7 ,but how i can hidden such as "1/6" on the StatusBar?

@cmhine
Copy link

cmhine commented Oct 14, 2013

What a hoofing life-saver. Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests