-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple ActiveAdmin extension for rails_setting_cache > 2 #60
Comments
Hi @ngelx. This gem a little bit dead because I don't use ruby in my work right now. But some work to update this gem to support v2 was done in branch https://github.com/artofhuman/activeadmin_settings_cached/tree/2.0 but I suppose not all. So, If you have a solution, we can merge it to upstream |
Also, there are some problems with CI, and I think we have to migrate to GitHub actions |
Hi @artofhuman, My first approach was to start updating this code, but after a while of struggling I dropped it in favor of a more simple KISS. To be honest, I don't see the point on having most of the logic in clases Coercions, Model and What I would recommend to do is to rebuild this gem following this kiss principe. We can put a note on the readme about the breaking change with version 2, which BTW was most probably going to happen anyway just for the upgrade to rails-settings-cache to v2. Cleaner code, easy code, easier to maintain. Second option is to just start a new gem, something very original like activeadmin_settings_cached_2 😄 I don't have much time, but I can work on this on some free time. Let me know your thoughts. |
@ngelx Sorry for delay. I agree that code may be cleaner, and maybe it's not necessary to do some coercions, etc. If you want, I can give you maintenance rights for this repo. |
No problem at all! thanks. As you mentioned before, I will also moved CI to Github actions. |
ActiveAdmin interface for rails_setting_cache > 2
This is an ActiveAdmin extension to add the interface to handle rails-setting-cached v2. For prior version I was using this gem but seems to be dead or with no activity.
Link to the gist ActiveAdmin interface for v2
The text was updated successfully, but these errors were encountered: