Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --reset to default tailscale up arguments #457

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fredrikekre
Copy link
Contributor

This patch adds --reset to the default tailscale up arguments which reset all non-default arguments to their defaults. This behavior matches what is documented in the README:

Flags are not persisted between runs; you must specify all flags each
time.

Fixes #455.

This patch adds `--reset` to the default `tailscale up` arguments which
reset all non-default arguments to their defaults. This behavior matches
what is documented in the README:

> Flags are not persisted between runs; you must specify all flags each
  time.

Fixes artis3n#455.
@McSim85
Copy link
Contributor

McSim85 commented Apr 3, 2024

Let me add my 2 cents.
I prefer to run the role with state: absent -> state: present, if cli parameters has changed.
That will bring less unexpected problems.

@artis3n
Copy link
Owner

artis3n commented Apr 5, 2024

For others - discussing this PR in #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] tailscale up fails when changing non-default flags
3 participants