From 1c07ee651802e9f8d62418821afbdcbeff4a7ba7 Mon Sep 17 00:00:00 2001 From: Nathan Villaescusa Date: Fri, 10 May 2024 17:19:53 -0700 Subject: [PATCH] Comments --- clients/mssql/store.go | 2 +- clients/shared/sweep.go | 2 +- clients/snowflake/util.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/mssql/store.go b/clients/mssql/store.go index 3ed35192a..6405a9d6c 100644 --- a/clients/mssql/store.go +++ b/clients/mssql/store.go @@ -52,7 +52,7 @@ func (s *Store) specificIdentifierFor(topicConfig kafkalib.TopicConfig, table st return NewTableIdentifier(getSchema(topicConfig.Schema), table) } -// IdentifierFor returns a generic [types.TableIdentifier] interface for a [TopicConfig] + table name. +// IdentifierFor returns a generic [sql.TableIdentifier] interface for a [TopicConfig] + table name. func (s *Store) IdentifierFor(topicConfig kafkalib.TopicConfig, table string) sql.TableIdentifier { return s.specificIdentifierFor(topicConfig, table) } diff --git a/clients/shared/sweep.go b/clients/shared/sweep.go index 155446f60..fda483b80 100644 --- a/clients/shared/sweep.go +++ b/clients/shared/sweep.go @@ -30,7 +30,7 @@ func Sweep(dwh destination.DataWarehouse, topicConfigs []*kafkalib.TopicConfig, } if ddl.ShouldDeleteFromName(tableName) { - // TODO: Rewrite this to pass a [types.TableIdentifiers] to [DropTemporaryTable] + // TODO: Rewrite this to pass a [sql.TableIdentifiers] to [DropTemporaryTable] err = ddl.DropTemporaryTable(dwh, fmt.Sprintf("%s.%s.%s", dbAndSchemaPair.Database, tableSchema, tableName), true) if err != nil { return err diff --git a/clients/snowflake/util.go b/clients/snowflake/util.go index 29fbeb6c1..53ec118f7 100644 --- a/clients/snowflake/util.go +++ b/clients/snowflake/util.go @@ -9,7 +9,7 @@ import ( "github.com/artie-labs/transfer/lib/typing/columns" ) -// addPrefixToTableName will take a [types.TableIdentifier] and add a prefix in front of the table. +// addPrefixToTableName will take a [sql.TableIdentifier] and add a prefix in front of the table. // This is necessary for `PUT` commands. func addPrefixToTableName(tableID sql.TableIdentifier, prefix string) string { return tableID.WithTable(prefix + tableID.Table()).FullyQualifiedName()