Support updating a deployment #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danafallon
commented
Jul 25, 2024
| @@ -38,11 +41,12 @@ func (r *DeploymentResource) Schema(ctx context.Context, req resource.SchemaRequ | |||
| resp.Schema = schema.Schema{ | |||
| MarkdownDescription: "Artie Deployment resource", | |||
| Attributes: map[string]schema.Attribute{ | |||
| "uuid": schema.StringAttribute{Computed: true}, | |||
| "uuid": schema.StringAttribute{Computed: true, PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown()}}, | |||
| "company_uuid": schema.StringAttribute{Computed: true, PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown()}}, | |||
There was a problem hiding this comment.
@Tang8330 UseStateForUnknown was the answer to the issue we were talking about at lunch 🎉
|
Nice!
…On Thu, Jul 25, 2024 at 1:36 PM Dana Fallon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In internal/provider/deployment_resource.go
<#8 (comment)>
:
> @@ -38,11 +41,12 @@ func (r *DeploymentResource) Schema(ctx context.Context, req resource.SchemaRequ
resp.Schema = schema.Schema{
MarkdownDescription: "Artie Deployment resource",
Attributes: map[string]schema.Attribute{
- "uuid": schema.StringAttribute{Computed: true},
+ "uuid": schema.StringAttribute{Computed: true, PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown()}},
+ "company_uuid": schema.StringAttribute{Computed: true, PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown()}},
@Tang8330 <https://github.com/Tang8330> UseStateForUnknown was the answer
to the issue we were talking about at lunch 🎉
—
Reply to this email directly, view it on GitHub
<#8 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBVGKBHALF2DN3Y43GR42LZOFOWTAVCNFSM6AAAAABLPITPUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBQGQZDIMZXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go install .cd examples/deployments/TF_LOG=INFO tf apply