Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to introduce client interceptors? #107

Open
i0jupiter opened this issue May 22, 2023 · 1 comment
Open

Any plans to introduce client interceptors? #107

i0jupiter opened this issue May 22, 2023 · 1 comment

Comments

@i0jupiter
Copy link

The Twirp canonical implementation supports both server and client interceptors. This allows us to do similar things for both clients and servers, such as emit specific metrics based on type of request. In the Ruby stack, this facility exists only for the server side. Are there any plans to introduce client interceptors as well?

As a side note, what twirp-ruby calls service hook is actually server interceptor in the canonical lingo. Any reason for this naming choice?

@mtodd
Copy link

mtodd commented Nov 2, 2023

ref #66 for similar/equivalent "around hook" suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants