-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Value property changing to null does not clear Input element's text if clearOnSameDateClick is false #693
Comments
null
does not clear Input element's text if clearOnSameDateClick
is false
null
does not clear Input element's text if clearOnSameDateClick
is false
Hi @MutatedGamer! I'm sorry for the late reply, I haven't been able to check GitHub lately. I'll update here when it's fixed. |
I did a few changes on #706 and released Let me know how it goes so I can release a stable version or fix it if needed 🙌🏽 |
Hi @arthurdenner, Thanks for the quick turnaround. I tested the beta version with my above sandbox and it seems to be fixed. I sadly had to move away from this dependency for my project because #176 is a bigger blocker. My project uses vitejs for its webpack, which results in the entire app crashing in production when you try to load a datepicker. Hope you can find time to address that bug too - I'd love to move back to this dependency since I think it looks nicer than the standard "react-datepicker" 😄 |
Thanks for the feedback! Yea, I should get some time to look into that issue 😅 |
Closing as the fix is now published on |
🐛 bug report
Description of the problem
If a
SemanticDatepicker
has avalue
property being passed in, setting the property tonull
does not cause the innerInput
elementvalue
to change ifclearOnsameDateClick
is false. This results in the text not updating, even though the value of the component has been updated.In the sandbox link below, perform the following actions:
SemanticDatepicker
has a correct value ofnull
, but the innerInput
has the old value.How has this issue affected you? What are you trying to accomplish?
This is a blocker when using
Formik
to handle the field's value. Specifically, I am trying to have Formik "reset" the form (I have a form inside a modal and want the form to clear when the modal is opened again). Formik'sresetForm()
will update all the field values, giving theSemanticDatepicker
a new default value ofnull
; visually, however, the form still has the previous value.Link to a sandbox: here
The text was updated successfully, but these errors were encountered: