Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen is flickering once presses back button #11

Open
its-veejay opened this issue Oct 28, 2013 · 2 comments
Open

Screen is flickering once presses back button #11

its-veejay opened this issue Oct 28, 2013 · 2 comments
Assignees

Comments

@its-veejay
Copy link

I found one more issue and below is the scenario to replicate it, please have a look on it.

Step 1: Bind a List with Data Template

                            </StackPanel>
                        </DataTemplate>

Step 2: On press of any list item image click it will show some other Panorma Item and once user press back button to see the list of images it will bind the list and while binding images from cache it Flicker and looks annoying as per user prospective.

@artem-zinnatullin
Copy link
Owner

Oh yeah, I faced that issue in my app. But problem is not in JetImageLoader.

You need to check ImageUri property for equality and call NotifyPropertyChanged() only if new value is not equals to previous.

Example of List item model (pseudo C#):

public class ListItemExample
{
    private string _imageUri;

    public string ImageUri
    {
            get { return _imageUri; }
            set
            {
                if (!String.Equals(value, _imageUri))
                {
                    _imageUri = value;
                    NotifyPropertyChanged();
                }
            }
    }
}

Do not call NotifyPropertyChanged() if image uri value was not changed because it will call JetImageLoader and it will do his work :)

@artem-zinnatullin
Copy link
Owner

May be I need to write that in help or example, thank you for the feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants