Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting back button after new tab should show same artwork #14

Open
IllyaMoskvin opened this issue Feb 8, 2019 · 2 comments
Open

Hitting back button after new tab should show same artwork #14

IllyaMoskvin opened this issue Feb 8, 2019 · 2 comments
Assignees

Comments

@IllyaMoskvin
Copy link
Contributor

No description provided.

@nikhiltri nikhiltri self-assigned this May 23, 2019
@nikhiltri
Copy link
Member

I'm not seeing a lot of options to set cache headers for the page that's served by the Chrome extension. We could use cookies to save the Data Hub response for, like, 10 seconds, but you wouldn't be able to cycle through works with browser's reload button anymore, which is a satisfying UX.

One alternative would be to cache a history of all the works a user has seen, and let people view their history. That would let people revisit works they may have seen a days ago. Still thinking it through.

@seeReadCode
Copy link

It looks like perhaps the cookies concept here has been abandoned.

IMHO the back functionality is less important than being able to access recently viewed art. (I often open a tab, jump to a site, and then realize I want to learn more about what I just saw for a split second).

Why not store the recently viewed art under a separate key in the local storage? Title and link should be enough. That could be added in updatePage. What do you think?

BTW, I'm looking at building a docker image that would feed CIA images to chromecast as a fill-in for the art gallery ambient mode (they haven't updated their art images in years).

Thanks for this extension!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants