-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to pair ceiling fan whereas pairing OK using FanLamp pro #19
Comments
Forcing the same seed, ID, group_index, cmd and args, here is what our component is generating for each variant: v1a: 02.01.02.1B.03.77.F8.B6.5F.2B.5E.00.FC.31.51.CC.FE.92.4C.2E.4A.73.FC.B5.67.60.11.29.50.0B.85 (31) v1b: 02.01.02.1B.03.F9.08.49.13.F0.69.25.4E.31.51.BA.AE.DC.02.24.CB.3B.B4.71.B7.E0.11.FC.F1.EC.4C (31) v2: 02.01.02.1B.16.F0.08.10.80.B8.66.E1.22.C6.F2.D3.A7.60.44.A4.9F.67.F6.B6.A2.22.8B.53.2B.7B.26 (31) v3: 02.01.02.1B.16.F0.08.10.80.B8.66.E1.22.C6.F2.D3.A7.60.44.A4.9F.67.F6.B6.42.DC.8B.53.2B.8B.F7 (31) The diff in ADV Indicator and ADV Data for v2 and v3 have already been tested as not impacting, to be confirmed. |
Another message, version Log v1:
|
@cRazyK67, I re align all I could on the encoding to match what "FanLamp Pro" app is effectively generating, could you please test if the pairing is now working with |
|
@cRazyK67 , |
@NicoIIT, Sorry, didn't see I didn't notice any effect of max_duration on pairing.
|
@cRazyK67, new attempt (type 0x0400 for v2/v3, limit seed to 0xFF and force group_index to 1 for v1a, ), available on EDIT: the |
@NicoIIT, Yeeesss!!! |
@cRazyK67 , that is great, but I may have broken the variant v1a for the other users 😄 Could you please help me again for a few new tests ? I would need you to try to pair your chandelier with variant v1a, with As it is pairing attempts, you should use a new forced_id each time to be sure it does work (or not) due to a previous pairing. Once done I will have identified exactly which change was needed, and I will try to revert all other changes and we would re- |
@NicoIIT works both variants without option max_duration: 10000 |
@cRazyK67, option max_duration is not the fix, it is just to give you more time to pair. The fix is done in the encoding of variant v1a. In between the test you did were it was not working, and the test you did where it worked I did 2 changes on encoding of variant v1a and I need to know which one is the needed one. You should not be able to re pair with the soft on both branches, only one can work, or none (because if both work it means that both changes are not mandatory and that then the previous version that was not working was in fact ... working ...) EDIT: OR that you were very lucky and had a generated seed in the working range (0.5% of the cases) 😄 |
@NicoIIT, Just repeated my actions
pairing successful log
1.2. compiled with config
pairing successful log
log
|
@cRazyK67, I really do not understand 😢 |
@NicoIIT, |
@cRazyK67, ok so it means the last changes were not the mandatory ones at the end, so I will revert the other changes one by one. |
@NicoIIT , I can do it late in the evening. |
I paired with the chandelier and control it |
@cRazyK67 , Hi again ! Sorry for the delay I took time to make a huge refactoring and to properly re align the encoders with what is done in the real apps. Available encoding / variants:
May I ask you to test this (hopefully last) new feature on dev branch ? I did a lot of tests on my side already but you have a lot of Chandelier so you are my preferred beta tester 😄. Thanks a lot in advance ! |
@NicoIIT In 2 hours, I'm leaving for a 7-day vacation. |
As per reference in PR #17 , some ceiling fan cannot pair using this component, despite managing to pair and to be controlled using FanLamp pro phone app.
They cannot be pair neither using any variant of previous component:
github://flicker581/esphome-lampsmart
At pairing time, the FanLamp pro app is producing 3 different advertising as per logs extracted from android:
The goal of his issue is to find the differences with what is effectively generated by our component and try to get ride of those diffs.
The text was updated successfully, but these errors were encountered: