feat(useMikadoGraph): the prerequisite form can only be opened once

arnolanglade · Nov 9, 2023 · 7b4008b · 7b4008b
1 parent 8b0ea61
commit 7b4008b
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 7 deletions.
diff --git a/app/mikado-graph/component/mikado-graph.tsx b/app/mikado-graph/component/mikado-graph.tsx
@@ -1,11 +1,11 @@
 'use client';
 
-import React, { useEffect } from 'react';
+import React from 'react';
 import { StatusView } from '@/api/mikado-graph/mikado-graph';
 import AddPrerequisiteForm from '@/mikado-graph/component/add-prerequisite-form';
 import { Translation } from '@/tools/i18n/intl-provider';
 import {
-  Controls, Handle, MiniMap, Position, ReactFlow, useEdgesState, useNodesState,
+  Controls, Handle, MiniMap, Position, ReactFlow,
 } from 'reactflow';
 import {
   GaolData, MikadoGraph, NewPrerequisiteData, PrerequisiteData,

diff --git a/app/mikado-graph/mikado-graph.usecase.spec.tsx b/app/mikado-graph/mikado-graph.usecase.spec.tsx
@@ -198,10 +198,7 @@ describe('useMikadoGraph', () => {
       const mikadoGraphId = uuidv4();
       const mikadoGraphView = aMikadoGraphView({ mikadoGraphId, prerequisites: [] });
       const { result } = renderHook(() => useMikadoGraph(mikadoGraphView), {
-        wrapper: createWrapper(
-          {},
-          { 'prerequisite.notification.add-prerequisite.success': 'The prerequisite has been added' },
-        ),
+        wrapper: createWrapper(),
       });
 
       await act(() => result.current.openPrerequisiteForm(mikadoGraphId));
@@ -217,6 +214,26 @@ describe('useMikadoGraph', () => {
         target: 'new-prerequisite',
       });
     });
+
+    test('The prerequisite form can only be opened once', async () => {
+      const parentId = uuidv4();
+      const mikadoGraphView = aMikadoGraphView({
+        mikadoGraphId: parentId,
+        prerequisites: [
+          { prerequisiteId: 'new-prerequisite', parentId: uuidv4() },
+        ],
+      });
+      const { result } = renderHook(() => useMikadoGraph(mikadoGraphView), {
+        wrapper: createWrapper(),
+      });
+
+      await act(() => result.current.openPrerequisiteForm(parentId));
+
+      expect(result.current.mikadoGraph.nodes[1]).toMatchObject({
+        id: 'new-prerequisite',
+        parentId,
+      }); // 0: Goal + 1: prerequisite
+    });
   });
 
   describe('add prerequisite', () => {

diff --git a/app/mikado-graph/mikado-graph.usecase.tsx b/app/mikado-graph/mikado-graph.usecase.tsx
@@ -80,9 +80,11 @@ export default function useMikadoGraph(defaultMikadoGraphView: MikadoGraphView)
   const nodeHeight = 350;
 
   const openPrerequisiteForm = (parentId: string) => {
+    const prerequisiteWithoutNodeForm = mikadoGraphView.prerequisites.filter((p) => p.prerequisiteId !== 'new-prerequisite');
+
     setMikadoGraphView({
       ...mikadoGraphView,
-      prerequisites: [...mikadoGraphView.prerequisites, {
+      prerequisites: [...prerequisiteWithoutNodeForm, {
         prerequisiteId: 'new-prerequisite',
         parentId,
         label: '',