You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But I think that naming can be confusing. At https://github.com/arnab39/cycleGAN-PyTorch/blob/master/model.py#L107 you named a_fake = self.Gab(b_real), the generator of a to b taking a b example should not generate the identity (a_idt)? In all examples I show, the followed nomenclature for generators is this Gxy, generator from x to y...
Assuming that, all generators naming are reversed. What do you think?
The text was updated successfully, but these errors were encountered:
Hi, your code is very clean thanks!
But I think that naming can be confusing. At https://github.com/arnab39/cycleGAN-PyTorch/blob/master/model.py#L107 you named
a_fake = self.Gab(b_real)
, the generator ofa
tob
taking ab
example should not generate the identity (a_idt)? In all examples I show, the followed nomenclature for generators is this Gxy, generator from x to y...Assuming that, all generators naming are reversed. What do you think?
The text was updated successfully, but these errors were encountered: