Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Thread view shows messages outside of follow graph no matter their type #251

Open
KyleMaas opened this issue Feb 19, 2021 · 7 comments
Open
Labels
bug Something isn't working

Comments

@KyleMaas
Copy link
Collaborator

Thread view does not filter messages based on type, which means messages may be shown as outside of follow graph even if we don't know their type (whether they're posts or not) or are private.

@KyleMaas KyleMaas added the bug Something isn't working label Feb 19, 2021
@arj03
Copy link
Owner

arj03 commented Feb 19, 2021

Right, that should be relatively easy to fix though

@KyleMaas
Copy link
Collaborator Author

Yep. Just didn't want to forget about it.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Jul 6, 2021

Actually, this might not be so simple. Messages outside of the follow graph are known about only by their IDs by being mentioned in other messages. Which means without fetching them, we can't get their type. So...I'm not sure this is actually possible to fix.

@arj03
Copy link
Owner

arj03 commented Jul 6, 2021

Right, but we can implement some kind of warning system for that, and maybe a small cache so that you don't have to fetch the messages again. This would be very important for blocked users.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Jul 6, 2021

I think I'm going to be a bit out of my league on that - mind taking this one?

@arj03
Copy link
Owner

arj03 commented Jul 6, 2021

Sure, a bit busy now but I'll try keeping this in mind

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Jul 6, 2021

Yeah, no problem. Just trying to go through old bugs and see which ones are still valid.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants