-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing First Line, But It's Not Empty #29
Comments
Same here. The first line is never empty for me, even if I add a long blank at the beginning of the audio. I removed the shift() function, and it seems to work fine. Also, I often see [BLANK_AUDIO] at the end of my transcript array, which can be easily filtered out. |
I didn't set language to auto, thats why it was translating the text |
This submission addresses the following two issues: 1. The first line is not always empty. Directly shifting the first line can cause processing failures for short audio clips. A better approach is to use a blank line filter to remove any potential empty lines. 2. A `null` model return does not necessarily indicate a runtime error. It may signify that some audio clips do not contain text recognizable by the model. In such cases, an empty response should be returned instead of triggering a code error. Related issues: 1: ariym#46 2: ariym#29
I've been seeing empty transcription results, and did some digging to find that you're trying to remove the first line assuming that it is empty. In my testing, it's never empty. Perhaps you could create a more elegant solution that looks for empty array elements after it's parsed and then remove those?
whisper-node/src/tsToArray.ts
Line 11 in 92e8b86
The text was updated successfully, but these errors were encountered: