Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing First Line, But It's Not Empty #29

Open
recursivecodes opened this issue Dec 5, 2023 · 2 comments
Open

Removing First Line, But It's Not Empty #29

recursivecodes opened this issue Dec 5, 2023 · 2 comments

Comments

@recursivecodes
Copy link

I've been seeing empty transcription results, and did some digging to find that you're trying to remove the first line assuming that it is empty. In my testing, it's never empty. Perhaps you could create a more elegant solution that looks for empty array elements after it's parsed and then remove those?

// 2. remove the first line, which is empty

@EightPool
Copy link

Same here. The first line is never empty for me, even if I add a long blank at the beginning of the audio. I removed the shift() function, and it seems to work fine. Also, I often see [BLANK_AUDIO] at the end of my transcript array, which can be easily filtered out.

@valoricDe
Copy link

valoricDe commented Sep 25, 2024

Could it be that the first line is the translation?
I recorded in german but my first line was in english

I didn't set language to auto, thats why it was translating the text

Leask added a commit to Leask/whisper-node that referenced this issue Dec 28, 2024
This submission addresses the following two issues:

1.  The first line is not always empty. Directly shifting the first line can cause processing failures for short audio clips. A better approach is to use a blank line filter to remove any potential empty lines.

2.  A `null` model return does not necessarily indicate a runtime error. It may signify that some audio clips do not contain text recognizable by the model. In such cases, an empty response should be returned instead of triggering a code error.

Related issues:
1: ariym#46
2: ariym#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants