Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add preallocated and indexed MSMs #306

Closed
wants to merge 1 commit into from
Closed

add preallocated and indexed MSMs #306

wants to merge 1 commit into from

Conversation

winston-h-zhang
Copy link
Contributor

Upstream fixes for argumentcomputer/grumpkin-msm#13, just matching the names and benchmarking

@winston-h-zhang
Copy link
Contributor Author

!gpu-benchmark

@winston-h-zhang winston-h-zhang mentioned this pull request Feb 9, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Benchmark for 42a9f16

Click to view benchmark
Test Base PR %
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-0 8.4±0.10s 8.6±0.10s +2.38%
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-1038732 112.0±1.91s 108.3±1.69s -3.30%
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-121228 16.1±0.11s 16.6±0.13s +3.11%
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-22924 12.7±0.13s 13.1±0.17s +3.15%
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-252300 30.0±0.29s 29.5±0.27s -1.67%
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-514444 57.8±0.85s 56.7±0.54s -1.90%
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-55692 22.8±0.41s 23.3±0.48s +2.19%
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-6540 14.5±0.14s 14.9±0.20s +2.76%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-0 66.0±0.73ms 91.5±0.87ms +38.64%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-1038732 788.5±4.28ms 878.3±2.48ms +11.39%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-121228 124.4±0.77ms 160.6±0.96ms +29.10%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-22924 79.8±0.66ms 112.0±0.61ms +40.35%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-252300 209.7±0.93ms 278.9±1.64ms +33.00%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-514444 425.1±1.57ms 480.8±1.74ms +13.10%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-55692 124.5±1.41ms 160.6±1.58ms +29.00%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-6540 78.5±0.55ms 112.2±0.46ms +42.93%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-0 45.9±0.32ms 46.7±0.36ms +1.74%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-1038732 368.2±1.38ms 431.1±1.98ms +17.08%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-121228 70.9±0.32ms 84.5±0.51ms +19.18%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-22924 71.6±0.41ms 72.5±0.60ms +1.26%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-252300 134.0±0.98ms 161.8±0.64ms +20.75%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-514444 210.0±0.97ms 248.5±0.76ms +18.33%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-55692 109.2±0.36ms 110.0±0.44ms +0.73%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-6540 52.9±0.09ms 53.8±0.24ms +1.70%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-0 26.2±0.22ms 27.3±0.37ms +4.20%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-1038732 286.3±4.03ms 348.8±2.36ms +21.83%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-121228 38.4±1.65ms 47.2±0.95ms +22.92%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-22924 48.9±0.95ms 50.4±0.86ms +3.07%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-252300 91.4±3.41ms 114.8±2.88ms +25.60%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-514444 151.0±3.82ms 187.3±4.79ms +24.04%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-55692 81.4±1.11ms 83.8±1.96ms +2.95%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-6540 32.9±0.35ms 34.8±0.75ms +5.78%

storojs72
storojs72 reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@storojs72 storojs72 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a temporate solution, isn't it? Why not merge indices branch of grumpkin-msm repository into its dev and avoid this patch to Arecibo at al?

@huitseeker huitseeker mentioned this pull request Feb 18, 2024
Closed
@huitseeker
Copy link
Contributor

Closing in favor of #374

@huitseeker huitseeker closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storojs72 storojs72 storojs72 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winston-h-zhang @huitseeker @storojs72