Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Automatic" mode for "Initial Sync Priority" option #6

Open
rokoblox opened this issue Sep 7, 2024 · 4 comments
Open

"Automatic" mode for "Initial Sync Priority" option #6

rokoblox opened this issue Sep 7, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@rokoblox
Copy link

rokoblox commented Sep 7, 2024

Sometimes small changes such as tool configurations are made inside roblox studio without the need to connect to argon, and sometimes files are edited offline, this means that I have to choose between the changes that I wish to prioritize over the others.

I thought of a solution to this problem by having Argon record the last sync time in the place in studio, and compare it with the "Last Modified" date of the luau file on the filesystem. If a file was modified after the last sync, it will prioritize changes made on the file system. If Argon detects changes between a file and its corresponding script in the place in studio, but finds that the file was last modified before the last sync, it will prioritize the changes in studio.

@DervexDev
Copy link
Member

I like this idea but it's very expensive to read the metadata of every file in the filesystem on each Argon startup, especially when the project gets bigger and bigger.

For now, I will stick to my original idea to fix this problem by creating "Connect Presets" which will allow to run sessions with predefined or customized settings with just one extra click directly from the main page.

@DervexDev DervexDev added the enhancement New feature or request label Sep 7, 2024
@rokoblox
Copy link
Author

rokoblox commented Sep 7, 2024

I like this idea but it's very expensive to read the metadata of every file in the filesystem on each Argon startup, especially when the project gets bigger and bigger.

It's only necessary to read metadata of files that have detected changes.

@rokoblox
Copy link
Author

rokoblox commented Sep 7, 2024

Alternatively, having a VSCode extension notification that asks for user's permission before applying changes received from studio just like the plugin in studio does when receiving changes from the server.

@DervexDev
Copy link
Member

It's only necessary to read metadata of files that have detected changes.

Oh so you wanna read and compare the dates after connecting client to the server. In this case that's something that could be added.

Alternatively, having a VSCode extension notification that asks for user's permission before applying changes received from studio just like the plugin in studio does when receiving changes from the server.

CLI already has this feature. Will bring that functionality to the VS Code with the release of the 2.1 version as this is when I plan to implement better wrapper-CLI communication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants