Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add control flow to handle optional parameters for Serpent2 cards #186

Open
yardasol opened this issue Jan 18, 2023 · 0 comments
Open

Comments

@yardasol
Copy link
Contributor

Background and motivation

Certain Serpent2 cards have optional parameters. For example, the pop card has the following parameters:

set pop NPG NGEN NSKIP [ K0 BTCH NEIG ]

The bracketed values are optional. In the current implementation of SaltProc, a user using these optional parameters on the set pop card will get a ValueError: too many values to unpack on line 90 in serpent_depcode.py

Description of idea

We should add control flow to handle these optional inputs.

Implementation details

We will need to:

  1. Identify which cards SaltProc interacts with directly
  2. Implement control flow to handle any optional parameters

Potential snags

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant