Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address reviewers' comments #6

Open
smpark7 opened this issue Dec 16, 2024 · 0 comments
Open

Address reviewers' comments #6

smpark7 opened this issue Dec 16, 2024 · 0 comments
Assignees
Labels
Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Docs Is related to API documentation, website content, etc.

Comments

@smpark7
Copy link
Collaborator

smpark7 commented Dec 16, 2024

This issue can be closed when the following review comments are addressed:

The stated objective of the paper is to study MSR, but the equation the whole model is based on fails to represent the fundamental aspect of MSR i.e. the movement of precursors. The method can have an interest in general, as it claims to provide improved results in the proximity of CR, but the context of MSR is not supported from the very beginning of the paper.
As 1D slab geometries are considered, it seems from the description of the domains at figure 1 that the slab is taken, presumably, perpendicularly to the axis of the reactor (a mention to MSRE is made) and the heterogeneity of the graphite and CR is therefore represented in this simplified configuration. Anyway, it is difficult to understand why the specific focus on MSR had to be made, as the whole point of the work is not addressing the peculiarity of MSR.
Carefully check the paper for inconsistencies. Some suggestions here below:

  • Eq 1, although steady- state, has time dependence in the flux
  • Is there a specific reason why in eq 1 the cross section do not have space dependence?
  • It can be guessed that psi identifies the angular flux and phi the scalar flux, but the fundamental quantities should be defined
  • The text should be improved ... for example "where the 1/Σ factors in the streaming and source terms evaluate to very large values" is an incorrect expression in English
@smpark7 smpark7 added Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Docs Is related to API documentation, website content, etc. labels Dec 16, 2024
@smpark7 smpark7 self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Docs Is related to API documentation, website content, etc.
Projects
None yet
Development

No branches or pull requests

1 participant