Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD_SEV and other constants used in common code, but only defined for amd64 #21

Open
Jakob-Naucke opened this issue Jul 21, 2021 · 0 comments · May be fixed by #23
Open

AMD_SEV and other constants used in common code, but only defined for amd64 #21

Jakob-Naucke opened this issue Jul 21, 2021 · 0 comments · May be fixed by #23

Comments

@Jakob-Naucke
Copy link

#18 introduced some constants, e.g. AMD_SEV, in cpuid_amd64.go, and then used them in cpuid.go. They will be undefined when building on non-x86_64 architectures.
e.g. on s390x:

$ go get github.com/intel-go/cpuid
# github.com/intel-go/cpuid
go/pkg/mod/github.com/intel-go/[email protected]/cpuid.go:291:2: undefined: AMD_SME
go/pkg/mod/github.com/intel-go/[email protected]/cpuid.go:292:2: undefined: AMD_SEV
go/pkg/mod/github.com/intel-go/[email protected]/cpuid.go:293:2: undefined: AMD_PAGE_FLUSH_MSR
go/pkg/mod/github.com/intel-go/[email protected]/cpuid.go:294:2: undefined: AMD_SEV_ES

/cc @jimcadden

@zhsj zhsj linked a pull request Nov 6, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant