Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature and humidity update for channel 3 updates channel 0 #19

Open
ArmandoPueyos opened this issue Feb 16, 2024 · 0 comments
Open

Comments

@ArmandoPueyos
Copy link

setDoubleParam(PilatusThTemp0, temp);

When reading detector temp and humidity, there is an entry for Channel 3 that is unlikely to exist. And worse, if it exists it overrides Channel 0:

    if ((substr = strstr(this->fromCamserver, "Channel 3")) != NULL) {
        sscanf(substr, "Channel 3: Temperature = %fC, Rel. Humidity = %f", &temp, &humid);
        setDoubleParam(PilatusThTemp0, temp);
        setDoubleParam(PilatusThHumid0, humid);
    }

IMHO I believe this piece of code should be removed to avoid confusion.
However, I ignore if there is a case of Pilatus systems where the channels are numbered [1..3] instead of [0..2] by CamServer -- if that's the case then it should be properly documented, and set ADTemperature as well.

Thanks,
Armando

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant