Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

RTC methods should be singolar #50

Open
agdl opened this issue Mar 22, 2021 · 2 comments
Open

RTC methods should be singolar #50

agdl opened this issue Mar 22, 2021 · 2 comments
Assignees
@facchinm @Rocketct
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@agdl
Copy link
Member

agdl commented Mar 22, 2021

i.e setYear instead of setYears
@leonardocavagnis
Copy link
Collaborator

Hi @agdl,
This improvement will be included in the next release.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 21, 2023
@per1234 per1234 linked a pull request Sep 21, 2023 that will close this issue
Library revamping #106
Closed
@per1234 per1234 reopened this Sep 21, 2023
@per1234
Copy link
Contributor

per1234 commented Sep 21, 2023

@leonardocavagnis we should wait to close the issue until the pull request has been merged. I have linked the two together so that GitHub will do that automatically.

FYI, there is a special syntax you can use in your pull request messages to generate such linkages:

https://docs.github.com/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@facchinm facchinm

@Rocketct Rocketct

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Library revamping leonardocavagnis/Arduino_MachineControl
5 participants
@agdl @per1234 @facchinm @Rocketct @leonardocavagnis