Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Enhanced Code : Event Based System #465

Closed
VinceAxe opened this issue Apr 9, 2019 · 2 comments
Closed

[Feature Request] Enhanced Code : Event Based System #465

VinceAxe opened this issue Apr 9, 2019 · 2 comments

Comments

@VinceAxe
Copy link
Contributor

VinceAxe commented Apr 9, 2019

It might be helpful and interesting to consider all changes inside the model as Event.

Related Issue :

It has a lot of impact

@Phillipus
Copy link
Member

Phillipus commented Apr 9, 2019

The code already is event based and each change to the model is one or maybe several model events that only have meaning to the user. The code can't decide what has impact or not. Impact depends on circumstances. Changes can only be surfaced to the user by UI code and code that analyses the model.

Example #464 - when there is a reconnection, then the code iterates through every diagram to look for instances of the source and target objects and tries to reconnect them. If one or other is missing then the connection is removed from the diagram so it is not orphaned. This will in fact lead to several events that all go on the undo stack. Whether event driven or not, that code had to be manually constructed to handle that.

So, in those issues, event driven or not makes no difference.

@jbsarrodie
Copy link
Member

@VinceAxe Might be good for you to become familiar with the codebase and especially EMF. This should help you understand how all this works and why such suggestion by itself doesn't solve anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants