Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip SSL Verification Flag #164

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

pchar
Copy link

@pchar pchar commented Mar 26, 2021

Hi,
I've added a simple flag to the clone dialog that allow tho add ex:
[http "https://localhost:3000"] sslVerify = false
into the $home/.gitconfig file
this will skip the SSL handshake verification during the clone process, i've made this changes because in my current work environment was so easy to add the self signed CA root to the keystore

please also see the issue
#113

Let me know if you thing that culd be a usefull changes
Regards

@jbsarrodie
Copy link
Member

Hi,

Thank you for this.

Please note that the intended process for code submission is to first discuss the goal with Phil and I before actually working on it (in order to avoid wasting your time in case similar work is already started on our side or if we already discussed about a feature and decided not to add it) and then open a draft pull request. For a more detailed presentation of this, see this wiki page.

Phil and I been working on other features in Archi at the moment, we won't be able to look at your code anytime soon.

In addition, note that we've stopped working on this plugin and started a full rewrite named coArchi2 (not ready for production yet).

Regards,

JB

@pchar
Copy link
Author

pchar commented Mar 26, 2021

Hi JB,
yes you are right but in this case I had to make a quick fix because we were blocked in our organisation and i had to make a quick fix to solve our situation.
I submitted the patch because just to not waste the code and because there were an open issue on this topic

@Phillipus
Copy link
Member

Thanks for sharing but as JB says we prefer to receive draft PRs as it makes it easier to discuss them.

In this case, for now, users can manually add the setting to the .gitconfig file so it's not urgent. When we restart work on coArchi 2 we might think of a way to make it easier to set this. Also, it might be something that a user might set per repository rather than globally.

@pchar
Copy link
Author

pchar commented Mar 27, 2021

Just for your info the path set the ssl ignore URL by URL so it focus on one specific repository not globally , but it's true that it write on the .gitconfig home

@Phillipus Phillipus force-pushed the master branch 2 times, most recently from 8ae10f9 to 5551cf9 Compare November 14, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants