Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom token management #1161

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Add custom token management #1161

wants to merge 11 commits into from

Conversation

redDwarf03
Copy link
Member

Description

Fixes #1160

Type of change

  • New feature (non-breaking change which adds functionality)

Material used:

Please delete options that are not relevant.

  • iOS (Smartphone/Tablet)

How Has This Been Tested?

  • Add / Hide custom tokens
  • In add custom sheet, search token by address or directly in the user's balance
  • In swap sheet, search token by address or in custom list

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Useful info for the reviewer:

@redDwarf03 redDwarf03 linked an issue Nov 5, 2024 that may be closed by this pull request
Add custom token #1160
Open
@redDwarf03 redDwarf03 requested a review from Chralu November 5, 2024 08:59
@redDwarf03 redDwarf03 mentioned this pull request Nov 5, 2024
Closed
Chralu
Chralu reviewed Nov 5, 2024
View reviewed changes
lib/application/tokens/tokens.dart Outdated Show resolved Hide resolved
lib/domain/models/token_parser.dart Outdated Show resolved Hide resolved
lib/domain/models/token_parser.dart Show resolved Hide resolved
lib/infrastructure/repositories/tokens/tokens.repository.dart Outdated Show resolved Hide resolved
lib/ui/views/add_custom_token/bloc/provider.dart Outdated Show resolved Hide resolved
lib/ui/views/add_custom_token/bloc/provider.dart Show resolved Hide resolved
lib/ui/views/add_custom_token/layouts/add_custom_token_sheet.dart Outdated Show resolved Hide resolved
@redDwarf03 redDwarf03 marked this pull request as draft November 5, 2024 21:49
@redDwarf03 redDwarf03 marked this pull request as ready for review November 8, 2024 14:27
@redDwarf03 redDwarf03 force-pushed the 1160-add-custom-token branch from bbe2bcd to 15d9b7f Compare December 10, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chralu Chralu Chralu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom token
2 participants
@redDwarf03 @Chralu