Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better guard for generate_frontend_configuration() #11701

Open
jacobtylerwalls opened this issue Dec 19, 2024 · 0 comments
Open

Find a better guard for generate_frontend_configuration() #11701

jacobtylerwalls opened this issue Dec 19, 2024 · 0 comments

Comments

@jacobtylerwalls
Copy link
Member

In both core and arches app templates, we have a guard around the call to generate_frontend_configuration() that tries to avoid running this multiple times for every arches application:

def ready(self):
if settings.APP_NAME.lower() == self.name:
generate_frontend_configuration()

However, it checks APP_NAME, which isn't very reliable, since it is configurable through the UI, and comes with a default of "Arches" that might not even match the self.name in the AppConfig class.

In v8 we should find a better guard or remove the guard entirely.

@chiatt chiatt added this to pipeline Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant