From 9605a1a1238f76f498c9cdb7739baf0fd072d1d3 Mon Sep 17 00:00:00 2001
From: Aaron Gundel <aaron.gundel@gmail.com>
Date: Mon, 2 Dec 2024 15:19:10 -0700
Subject: [PATCH] update page names to conform to patterns, pr feedback

---
 .../scheme/report/SchemeSection.vue           |  6 ++--
 .../src/arches_lingo/pages/SchemePage.vue     | 28 ++++++++++++-------
 .../src/arches_lingo/pages/SchemeReport.vue   | 23 ---------------
 arches_lingo/src/arches_lingo/routes.ts       | 10 -------
 4 files changed, 20 insertions(+), 47 deletions(-)
 delete mode 100644 arches_lingo/src/arches_lingo/pages/SchemeReport.vue

diff --git a/arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue b/arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue
index 972b5921..7d627e7e 100644
--- a/arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue
+++ b/arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue
@@ -6,8 +6,6 @@ const { $gettext } = useGettext();
 const props = defineProps<{
     titleText: string;
 }>();
-
-const buttonText = $gettext(`Add ${props.titleText}`);
 </script>
 
 <template>
@@ -16,7 +14,7 @@ const buttonText = $gettext(`Add ${props.titleText}`);
             <h2>{{ props.titleText }}</h2>
             <div>
                 <Button
-                    :label="buttonText"
+                    :label="$gettext(`Add ${props.titleText}`)"
                     @click="$emit('openEditor')"
                 ></Button>
             </div>
@@ -34,7 +32,7 @@ const buttonText = $gettext(`Add ${props.titleText}`);
 .section .header {
     display: flex;
     align-items: center;
-    border-bottom: 1px solid #ddd;
+    border-bottom: 1px solid var(--p-menubar-border-color);
 }
 .section .header h2 {
     flex: 1;
diff --git a/arches_lingo/src/arches_lingo/pages/SchemePage.vue b/arches_lingo/src/arches_lingo/pages/SchemePage.vue
index 6ea028ee..536a8ef8 100644
--- a/arches_lingo/src/arches_lingo/pages/SchemePage.vue
+++ b/arches_lingo/src/arches_lingo/pages/SchemePage.vue
@@ -1,15 +1,23 @@
 <script setup lang="ts">
-import { inject } from "vue";
-
-import { displayedRowKey } from "@/arches_lingo/constants.ts";
-
-import type { DisplayedRowRefAndSetter } from "@/arches_lingo/types";
-
-const { displayedRow } = inject(
-    displayedRowKey,
-) as unknown as DisplayedRowRefAndSetter;
+import Splitter from "primevue/splitter";
+import SplitterPanel from "primevue/splitterpanel";
+import SchemeLicense from "@/arches_lingo/components/scheme/report/SchemeLicense.vue";
+import SchemeNote from "@/arches_lingo/components/scheme/report/SchemeNote.vue";
+import SchemeUri from "@/arches_lingo/components/scheme/report/SchemeUri.vue";
+import SchemeStandard from "@/arches_lingo/components/scheme/report/SchemeStandard.vue";
+import SchemeAuthority from "@/arches_lingo/components/scheme/report/SchemeAuthority.vue";
 </script>
 
 <template>
-    <pre style="text-wrap: auto">{{ displayedRow }}</pre>
+    <div>
+        <Splitter>
+            <SplitterPanel>
+                <SchemeNote />
+                <SchemeAuthority />
+                <SchemeStandard />
+                <SchemeLicense />
+                <SchemeUri />
+            </SplitterPanel>
+        </Splitter>
+    </div>
 </template>
diff --git a/arches_lingo/src/arches_lingo/pages/SchemeReport.vue b/arches_lingo/src/arches_lingo/pages/SchemeReport.vue
deleted file mode 100644
index 536a8ef8..00000000
--- a/arches_lingo/src/arches_lingo/pages/SchemeReport.vue
+++ /dev/null
@@ -1,23 +0,0 @@
-<script setup lang="ts">
-import Splitter from "primevue/splitter";
-import SplitterPanel from "primevue/splitterpanel";
-import SchemeLicense from "@/arches_lingo/components/scheme/report/SchemeLicense.vue";
-import SchemeNote from "@/arches_lingo/components/scheme/report/SchemeNote.vue";
-import SchemeUri from "@/arches_lingo/components/scheme/report/SchemeUri.vue";
-import SchemeStandard from "@/arches_lingo/components/scheme/report/SchemeStandard.vue";
-import SchemeAuthority from "@/arches_lingo/components/scheme/report/SchemeAuthority.vue";
-</script>
-
-<template>
-    <div>
-        <Splitter>
-            <SplitterPanel>
-                <SchemeNote />
-                <SchemeAuthority />
-                <SchemeStandard />
-                <SchemeLicense />
-                <SchemeUri />
-            </SplitterPanel>
-        </Splitter>
-    </div>
-</template>
diff --git a/arches_lingo/src/arches_lingo/routes.ts b/arches_lingo/src/arches_lingo/routes.ts
index 3adabd95..a8d0cdab 100644
--- a/arches_lingo/src/arches_lingo/routes.ts
+++ b/arches_lingo/src/arches_lingo/routes.ts
@@ -59,16 +59,6 @@ export const routes = [
             requiresAuthentication: true,
         },
     },
-    {
-        path: "/scheme/:id/report",
-        name: "scheme",
-        component: () => import("@/arches_lingo/pages/SchemeReport.vue"),
-        meta: {
-            shouldShowNavigation: true,
-            shouldShowHierarchy: true,
-            requiresAuthentication: true,
-        },
-    },
 ];
 
 export const routeNames = {