Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating resource through the ArcGIS Pro plugin creates empty tiles in all nodes in location nodegroup #1330

Open
SDScandrettKint opened this issue Sep 5, 2024 · 2 comments

Comments

@SDScandrettKint
Copy link
Member

SDScandrettKint commented Sep 5, 2024

When creating a resource using the ArcGIS Pro "create resource" function, the output is a location nodegroup that has the geometry node populated, and everything else as None (except the BNG node if the function is enabled in the model).

image

All of the sub-nodes in the Location nodegroup should not be populated, but the plugin force creates everything as None.

This has been fixed in the HE fork of AfHER but not yet merged into core Arches. The fix can be found here: HistoricEngland/arches#153. This should be added to core Arches in the long term, but perhaps added to AfHER as a hotfix for now.

@aj-he
Copy link
Collaborator

aj-he commented Sep 6, 2024

@apeters - This issue appears to stem from the behaviour of get blank tile which, when adding a new tile through the node value api, creates the parent tile if necessary, along with one tile for each of the sibling cards.

I'm wondering if this behaviour is expected? If so, could you review the fix we added to our fork (at v6) HistoricEngland/arches#153 to see if it is viable? If so, we can apply a hotfix to arches-her now and submit a fix to 7.6.x

@apeters
Copy link
Member

apeters commented Sep 10, 2024

This honestly seems like a bug to me. I don't think we should have ever allowed for the creation of so called sibling tiles.
Unfortunately, this behaviour is now out in the "wild" so to speak.

Instead of changing how the update_node_value method behaves, we should instead allow users to pass in a parameter that then gets passed to get_blank_tile.

And because of that we should also probably update the Node api POST method to allow users to pass that same flag into the request that then passes that into the update_node_value method.

Hopefully that all makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Is Core Issue
Development

No branches or pull requests

3 participants