Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize porting updating materials cells on accelerator #1264

Open
3 of 6 tasks
grospelliergilles opened this issue Mar 13, 2024 · 2 comments
Open
3 of 6 tasks

Finalize porting updating materials cells on accelerator #1264

grospelliergilles opened this issue Mar 13, 2024 · 2 comments
Assignees
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane:materials Management of Constituents (Material/Environment) arcane Arcane Component enhancement New feature or request refactoring Code refactoring and cleanup

Comments

@grospelliergilles
Copy link
Member

grospelliergilles commented Mar 13, 2024

We need to complete the following tasks:

Top priority

  • Remove remaining memory transfers between Host and Accelerator
  • Keep list of memory holes in ConstituentConnectivityList when adding cells
  • Keep list of memory holes in MeshMaterialVariableIndexer::endUpdateAdd()
  • Do not copy on Host the list of added/removed cells in MeshMaterialModifier
  • Update ItemGroup associated to a constituent using accelerator API

Priority 2

  • Only update modified cells in AllEnvData::recomputeIncremental()
@grospelliergilles grospelliergilles added enhancement New feature or request arcane Arcane Component refactoring Code refactoring and cleanup arcane:accelerator Arcane Accelerator API/Runtime arcane:materials Management of Constituents (Material/Environment) labels Mar 13, 2024
@grospelliergilles grospelliergilles self-assigned this Mar 13, 2024
@DavidDureau
Copy link
Collaborator

@grospelliergilles , you did a good job and I agree with the optimizations you gave.

In addition, is it possible to port in arcane/src/arcane/materials/AllCellToAllEnvCellConverter.cc :

These methods are called when enableCellToAllEnvCellForRunCommand() is enable like in the real code and soon in Mahyco.

@grospelliergilles
Copy link
Member Author

Yes I will look at that.
But when all will be finished I think the class AllCellToAllEnvCellConverter will no longer be needed.
I think now all the data are available from device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane:materials Management of Constituents (Material/Environment) arcane Arcane Component enhancement New feature or request refactoring Code refactoring and cleanup
Projects
None yet
Development

No branches or pull requests

2 participants