Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Loggers #18

Open
narendasan opened this issue Oct 6, 2017 · 5 comments
Open

Various Loggers #18

narendasan opened this issue Oct 6, 2017 · 5 comments

Comments

@narendasan
Copy link
Member

e.g Log to file

@narendasan
Copy link
Member Author

Changes to /logger/log.go

@pattyjogal
Copy link

Hi! I would like to contribute to this issue, but I just had a question before I start:

Where is the best place to decide which logger to use/which file to log to? Would the user specify it when instantiating the arbor instance, or should it be in some settings class, or maybe on each call to logger (i.e. one function per logging method)?

I only ask because the latter option sounds cumbersome for devs, but I don't know where an appropriate place to store this info would be.

Thanks!

@narendasan
Copy link
Member Author

I would think probably the config.go file that users usually create when they make an arbor app @bcongdon thoughts?

@bcongdon
Copy link
Contributor

Yeah, config.go sounds like the right place. This should be an optional setting

@pattyjogal
Copy link

Ok, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants