From 84ef2cd5a8dcf5862e16460515a5c4e787ae5495 Mon Sep 17 00:00:00 2001 From: Giorgi Lagidze Date: Tue, 10 Sep 2024 20:51:28 +0400 Subject: [PATCH] remove todo comments --- packages/contracts/src/MajorityVotingBase.sol | 1 - packages/contracts/src/TokenVoting.sol | 1 - 2 files changed, 2 deletions(-) diff --git a/packages/contracts/src/MajorityVotingBase.sol b/packages/contracts/src/MajorityVotingBase.sol index 63dcdbb5..059e6c61 100644 --- a/packages/contracts/src/MajorityVotingBase.sol +++ b/packages/contracts/src/MajorityVotingBase.sol @@ -506,7 +506,6 @@ abstract contract MajorityVotingBase is _updateVotingSettings(_votingSettings); } - // todo TBD define if permission should be the same one as update settings /// @notice Updates the minimal approval value. /// @param _minApprovals The new minimal approval value. function updateMinApprovals( diff --git a/packages/contracts/src/TokenVoting.sol b/packages/contracts/src/TokenVoting.sol index e7c2d7d4..de34c24a 100644 --- a/packages/contracts/src/TokenVoting.sol +++ b/packages/contracts/src/TokenVoting.sol @@ -52,7 +52,6 @@ contract TokenVoting is IMembership, MajorityVotingBase { emit MembershipContractAnnounced({definingContract: address(_token)}); } - // todo double check the reinitializer version must be 2 /// @notice Initializes the plugin after an upgrade from a previous version. /// @param _minApprovals The minimal amount of approvals the proposal needs to succeed. function initializeFrom(