From b8b5ea57757717fe8f242a92d68a3b0c04fea041 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8r=E2=88=82=C2=A1?= Date: Mon, 27 May 2024 14:07:29 +0200 Subject: [PATCH] Minor edits --- packages/contracts/src/governance/MainVotingPlugin.sol | 4 ++-- packages/contracts/src/personal/PersonalSpaceAdminPlugin.sol | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/contracts/src/governance/MainVotingPlugin.sol b/packages/contracts/src/governance/MainVotingPlugin.sol index 83d26aa..b6b7865 100644 --- a/packages/contracts/src/governance/MainVotingPlugin.sol +++ b/packages/contracts/src/governance/MainVotingPlugin.sol @@ -149,8 +149,8 @@ contract MainVotingPlugin is Addresslist, MajorityVotingBase, IEditors, IMembers emit MemberRemoved(address(dao()), _account); } - /// @notice Removes msg.sender from the list of editors. If the last editors leaves the space, the space will become read only. - function leaveSpace() public { + /// @notice Removes msg.sender from the list of editors and members, whichever is applicable. If the last editor leaves the space, the space will become read-only. + function leaveSpace() external { if (isEditor(msg.sender)) { // Not checking whether msg.sender is the last editor. It is acceptable // that a DAO/Space remains in read-only mode, as it can always be forked. diff --git a/packages/contracts/src/personal/PersonalSpaceAdminPlugin.sol b/packages/contracts/src/personal/PersonalSpaceAdminPlugin.sol index db0844c..0f581bb 100644 --- a/packages/contracts/src/personal/PersonalSpaceAdminPlugin.sol +++ b/packages/contracts/src/personal/PersonalSpaceAdminPlugin.sol @@ -174,7 +174,7 @@ contract PersonalSpaceAdminPlugin is PluginCloneable, ProposalUpgradeable, IEdit } /// @notice Creates and executes a proposal that makes the DAO revoke any permission from the sender address - function leaveSpace() public { + function leaveSpace() external { IDAO.Action[] memory _actions; if (dao().hasPermission(address(this), msg.sender, MEMBER_PERMISSION_ID, bytes(""))) { _actions = new IDAO.Action[](1);