From 7b6ef2084fde4654c0ea3f1630d6bcd20c927964 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8r=E2=88=82=C2=A1?= Date: Fri, 5 Jan 2024 14:17:08 +0100 Subject: [PATCH] Linting fixes --- .../test/integration-testing/governance-plugins-setup.ts | 3 --- .../test/integration-testing/member-access-condition.ts | 6 ++---- .../contracts/test/unit-testing/governance-plugins-setup.ts | 2 -- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/packages/contracts/test/integration-testing/governance-plugins-setup.ts b/packages/contracts/test/integration-testing/governance-plugins-setup.ts index f140977..29d468c 100644 --- a/packages/contracts/test/integration-testing/governance-plugins-setup.ts +++ b/packages/contracts/test/integration-testing/governance-plugins-setup.ts @@ -20,7 +20,6 @@ import { PluginRepo__factory, PluginSetupProcessor, PluginSetupProcessor__factory, - DAO__factory, } from '@aragon/osx-ethers'; import {SignerWithAddress} from '@nomiclabs/hardhat-ethers/signers'; import {expect} from 'chai'; @@ -40,8 +39,6 @@ const pluginSettings: MajorityVotingBase.VotingSettingsStruct = { votingMode: 0, }; const minMemberAccessProposalDuration = 60 * 60 * 24; -const daoInterface = DAO__factory.createInterface(); -const pspInterface = PluginSetupProcessor__factory.createInterface(); describe('GovernancePluginsSetup processing', function () { let deployer: SignerWithAddress; diff --git a/packages/contracts/test/integration-testing/member-access-condition.ts b/packages/contracts/test/integration-testing/member-access-condition.ts index 240c470..eb17826 100644 --- a/packages/contracts/test/integration-testing/member-access-condition.ts +++ b/packages/contracts/test/integration-testing/member-access-condition.ts @@ -31,8 +31,8 @@ import { PluginSetupProcessor__factory, PluginRepoFactory__factory, PluginRepoRegistry__factory, - DAO__factory, IDAO, + DAO__factory, } from '@aragon/osx-ethers'; import {SignerWithAddress} from '@nomiclabs/hardhat-ethers/signers'; import {expect} from 'chai'; @@ -49,14 +49,12 @@ const pluginSettings: MajorityVotingBase.VotingSettingsStruct = { }; const minMemberAccessProposalDuration = 60 * 60 * 24; const daoInterface = DAO__factory.createInterface(); -const pspInterface = PluginSetupProcessor__factory.createInterface(); describe('Member Access Condition E2E', () => { let deployer: SignerWithAddress; let pluginUpgrader: SignerWithAddress; let alice: SignerWithAddress; let bob: SignerWithAddress; - let carol: SignerWithAddress; let psp: PluginSetupProcessor; let dao: DAO; @@ -69,7 +67,7 @@ describe('Member Access Condition E2E', () => { let memberAccessPlugin: TestMemberAccessPlugin; before(async () => { - [deployer, pluginUpgrader, alice, bob, carol] = await ethers.getSigners(); + [deployer, pluginUpgrader, alice, bob] = await ethers.getSigners(); // Get the PluginRepoFactory address const pluginRepoFactoryAddr: string = getPluginRepoFactoryAddress( diff --git a/packages/contracts/test/unit-testing/governance-plugins-setup.ts b/packages/contracts/test/unit-testing/governance-plugins-setup.ts index 79c6100..2c44373 100644 --- a/packages/contracts/test/unit-testing/governance-plugins-setup.ts +++ b/packages/contracts/test/unit-testing/governance-plugins-setup.ts @@ -9,7 +9,6 @@ import {deployTestDao} from '../helpers/test-dao'; import {getNamedTypesFromMetadata, Operation} from '../helpers/types'; import { abiCoder, - ADDRESS_ONE, ADDRESS_ZERO, EXECUTE_PERMISSION_ID, NO_CONDITION, @@ -17,7 +16,6 @@ import { UPDATE_ADDRESSES_PERMISSION_ID, UPDATE_MULTISIG_SETTINGS_PERMISSION_ID, UPDATE_VOTING_SETTINGS_PERMISSION_ID, - UPGRADE_PLUGIN_PERMISSION_ID, VotingMode, } from './common'; import {activeContractsList} from '@aragon/osx-ethers';