This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
fix(s3): remove s3 use in service, update litestream and add to docker-compose #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2024 09:44
…S3 from the service Also updates docker-compose so one can easily spin up the service and litestream if they wish
fedellen
reviewed
May 23, 2024
docker-compose.yaml
Outdated
| image: textury/arlocal:v1.1.35 | ||
| ports: | ||
| - '1984:1984' | ||
|
|
||
| arns-service: | ||
| profiles: ['test', '', 'litestream'] |
There was a problem hiding this comment.
the standard here is for the default services to have no profile. but you'll need docker compose 2.x+ to support that
There was a problem hiding this comment.
Core services should not use profiles per the docs
fedellen
approved these changes
May 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.