feat(helpers): net_packet_http request/response #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rscampos Maybe use these helpers in the existing signatures if possible? For example add themto the instrumentation tests. Then we can merge. |
rscampos
force-pushed
the
4346_net_packet_http_request
branch
2 times, most recently
from
b85e0fb
to
bedbced
Compare
NDStrahilevitz
approved these changes
Oct 20, 2024
| @@ -43,6 +43,8 @@ require ( | |||
| sigs.k8s.io/controller-runtime v0.18.2 | |||
| ) | |||
|
|
|||
| replace github.com/aquasecurity/tracee/signatures/helpers => ./signatures/helpers/ | |||
There was a problem hiding this comment.
Remove and update through types PR
|
@rscampos Merge at will once you do the types PR (which you can merge without +1 as far as i'm concerned) |
- Add `GetProtoHTTPRequestByName` to get http request header from the event `net_packet_http_request`; - Add `GetProtoHTTPResponseByName` to get http response header from the event `net_packet_http_response`;
rscampos
force-pushed
the
4346_net_packet_http_request
branch
from
bedbced
to
5a60f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4346
1. Explain what the PR does
bedbced temp go.mod just for test
a0c1304 feat(test): e2e integration test for new helpers
f5498d0 feat(helpers): net_packet_http request/response
f5498d0 feat(helpers): net_packet_http request/response
2. Explain how to test it
net_packet_http_requestornet_packet_http_response.GetProtoHTTPRequestByNameorGetProtoHTTPResponseByName.3. Other comments