fix(tests): possible out of range in integration #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
force-pushed
the
4255-fix-expect-all-in-order
branch
2 times, most recently
from
cd4862a
to
0c1d041
Compare
ExpectAllInOrderSequentially might try to access an index out of range depending on the number of events that are being checked. More about in issue aquasecurity#4255.
Two test cases were using ExpectAllInOrderSequentially helper function and passing by luck, since they emit more events than expected only beyond the expected events boundary. For that cases we should use ExpectAtLeastOneForEach helper function instead.
geyslan
force-pushed
the
4255-fix-expect-all-in-order
branch
from
0c1d041
to
ac47cab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #4255
1. Explain what the PR does
cd4862a fix(tests): use ExpectAtLeastOneForEach
11a262b fix(tests): possible out of range in integration
2. Explain how to test it
3. Other comments