Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add perimission checks to object #14582

Draft
wants to merge 1 commit into
base: 09-04-add_permission_check_to_account
Choose a base branch
from
Draft

add perimission checks to object #14582

wants to merge 1 commit into from
+456 −9

Conversation

runtian-zhou
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Sep 10, 2024 •
edited
Loading

⏱️ 1h 39m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-unit-coverage 18m 🟩 
rust-move-unit-coverage 14m 🟩 
rust-move-unit-coverage 14m 🟩 
rust-move-tests 10m 🟥 
rust-move-tests 9m 🟥 
general-lints 7m 🟩 🟩 🟩 🟩 
rust-cargo-deny 7m 🟩 🟩 🟩 🟩 
rust-move-tests 5m ⬜ 
rust-move-unit-coverage 5m ⬜ 
check-dynamic-deps 3m 🟩 🟩 🟩 🟩 
rust-move-tests 3m 🟥 
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 
file_change_determinator 48s 🟩 🟩 🟩 🟩 
file_change_determinator 43s 🟩 🟩 🟩 🟩 
permission-check 15s 🟩 🟩 🟩 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@runtian-zhou Graphite App
Copy link
Contributor Author

runtian-zhou commented Sep 10, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from da28781 to 006ad4c Compare September 10, 2024 17:29
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 381be20 to 6a1fe6d Compare September 10, 2024 17:30
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.4%. Comparing base (0161bbf) to head (2431b7b).

Additional details and impacted files 
@@                          Coverage Diff                           @@
##           09-04-add_permission_check_to_account   #14582   +/-   ##
======================================================================
  Coverage                                   59.4%    59.4%           
======================================================================
  Files                                        857      857           
  Lines                                     210762   210762           
======================================================================
  Hits                                      125197   125197           
  Misses                                     85565    85565

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 006ad4c to ef7abd3 Compare September 12, 2024 01:50
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 6a1fe6d to 9037ce3 Compare September 12, 2024 01:50
This was referenced Sep 12, 2024
Draft
Draft
Draft
Draft
Open
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from ef7abd3 to c38c2dd Compare September 17, 2024 05:09
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 9037ce3 to 843150a Compare September 17, 2024 05:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from c38c2dd to 95b6704 Compare September 17, 2024 21:23
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 843150a to 33a73d7 Compare September 17, 2024 21:23
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 95b6704 to 7394967 Compare September 18, 2024 06:23
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 33a73d7 to 9123ceb Compare September 18, 2024 06:23
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 7394967 to a091794 Compare September 18, 2024 17:52
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 9123ceb to 206e782 Compare September 18, 2024 17:52
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from a091794 to 67163ae Compare September 19, 2024 00:35
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 206e782 to 9c81c83 Compare September 19, 2024 00:35
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 67163ae to f10a3b3 Compare September 19, 2024 08:09
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 9c81c83 to 75362c4 Compare September 19, 2024 08:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from f10a3b3 to 5c9396f Compare October 4, 2024 20:56
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 75362c4 to 86c07b1 Compare October 4, 2024 20:57
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 5c9396f to 9935539 Compare October 5, 2024 01:54
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 86c07b1 to 0573a7b Compare October 5, 2024 01:54
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 9935539 to b927c02 Compare October 5, 2024 02:25
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 0573a7b to 6a446be Compare October 5, 2024 02:25
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from c25dfde to 8b9069f Compare November 26, 2024 00:48
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 73f8e6c to 5bda657 Compare November 26, 2024 00:48
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 8b9069f to e49c386 Compare November 26, 2024 04:13
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 5bda657 to 0db0474 Compare November 26, 2024 04:14
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from e49c386 to 594644d Compare November 26, 2024 18:07
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 0db0474 to a694326 Compare November 26, 2024 18:07
graphite-app[bot]
graphite-app bot reviewed Nov 26, 2024
View reviewed changes
aptos-move/framework/aptos-framework/sources/object.move
@@ -540,6 +546,10 @@ module aptos_framework::object {
to: address,
) acquires ObjectCore {
let owner_address = signer::address_of(owner);
assert!(
permissioned_signer::check_permission_exists(owner, TransferPermission { object }),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TransferPermission struct field name object needs to be explicitly specified when constructing the struct. Please update to TransferPermission { object: object } to match the struct definition.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 594644d to 7b805b0 Compare November 26, 2024 18:09
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from a694326 to 447384e Compare November 26, 2024 18:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 7b805b0 to 0d70077 Compare November 26, 2024 18:21
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 447384e to 28c5962 Compare November 26, 2024 18:21
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 0d70077 to 8e6ca98 Compare November 26, 2024 20:57
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 28c5962 to 5979d45 Compare November 26, 2024 20:57
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 8e6ca98 to 1302c7b Compare November 26, 2024 22:09
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 5979d45 to 732bca6 Compare November 26, 2024 22:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 1302c7b to 4bec214 Compare November 26, 2024 23:15
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 732bca6 to 61bb726 Compare November 26, 2024 23:15
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 4bec214 to 3e1120c Compare November 27, 2024 03:09
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 61bb726 to 747dc83 Compare November 27, 2024 03:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 3e1120c to 6f4f49a Compare November 27, 2024 06:59
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 747dc83 to 5ca365e Compare November 27, 2024 06:59
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 6f4f49a to bfc0817 Compare November 27, 2024 07:16
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 5ca365e to dffbce5 Compare November 27, 2024 07:17
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from bfc0817 to a8ca890 Compare November 27, 2024 07:49
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from dffbce5 to d8dad95 Compare November 27, 2024 07:49
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from a8ca890 to 20ce45e Compare November 27, 2024 08:22
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from d8dad95 to 1e81ef4 Compare November 27, 2024 08:22
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 20ce45e to f1841c6 Compare November 27, 2024 08:40
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 1e81ef4 to db21dee Compare November 27, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-aptos igor-aptos igor-aptos left review comments

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@junkil-park junkil-park Awaiting requested review from junkil-park junkil-park will be requested when the pull request is marked ready for review junkil-park is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin will be requested when the pull request is marked ready for review movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runtian-zhou @igor-aptos