-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Image Annotator #3362
Comments
@Nikhil-Nandagopal As with the text annotator, please share your idea of the experience. |
Time Estimation:
|
The package used here internally has problems with re-rendering because of how the package internally uses memoize, Based on a few open issue we were able to find out how we could update the image, but we see this happening for all other properties as well, this might not be scalable for the future needs. Now we have two other option before taking this up from scratch
Based on a further research we will be able to identify what package we can go forward with |
@wmdev0808 kindly look into the packages mentioned above and do a POC to figure out what fits us best. |
@somangshu , |
@marks0351 is there a way to disable this for at-least while we are developing? |
@wmdev0808 as discussed in out last call, we can take some inspiration from input widget, it disables dragging the widget when it is focused. Also this proposed solution limits the user to moving the widget only by the widget name. |
@wmdev0808 you cud also check how table widget columns are dragged to change order without the widget getting dragged. |
@somangshu , I've talked about the issue with other guys, but we could not figure it out |
@somangshu , @marks0351 provided a solution, so I am not blocked |
I was trying the widget today and I have a couple of questions:
|
Design Handoff Link for Image Annotatorhttps://www.figma.com/file/w9CaXHF5iYcrLtiEbAHcFu/Original-Theme-Widgets-Library?node-id=1620%3A9821 |
Hi @areyabhishek,
|
@wmdev0808 the default annotation object is too complicated. Can we simplify its structure from
to
data and geometry don't need to be separate and we can rename the type property to shape to make it more intuitive There's no way to delete or resize/move an annotation. This is important because most annotation work is data cleanup. The group drag / resize keeps getting triggered when I use the annotate option We also need an option to let the user annotate from a drop-down instead of free form text because annotations are used to tag objects and free text is prone to tagging errors |
Hi @Nikhil-Nandagopal , |
Hi @areyabhishek and @Nikhil-Nandagopal,
|
Updated 22 Dec 6PM IST
|
@somangshu,
We are required to make decision which package for extension we will be using as an underlying package. |
@wmdev0808 based on the your comment above, Here are my thoughts
Once these questions are answered, we can move ahead. |
We just choose react-image-annotation for popularity(github star) and more functionalities(for example support for various selector types, RECTANGLE, OVAL, POINT, even custom one, however, react-picture-annotation just supports RECTANGLE)
|
@wmdev0808 thanks for the clarity on this @dilippitchika we would like to have a discussion around this with you cc @sbalaji1192 |
@somangshu @wmdev0808 We can have a discussion on this. I also have some other details to share. I was checking react-image-annotation and the resize issue is open since the last 2+ years. I don't there's any improvement on that front. I still think it's common to have the resize and move feature for annotation projects. Can compromise non rectangular shapes as Most ML training data deals with rectangular bounding boxes. Will block time for discussion. |
Discussions with @wmdev0808 and @somangshu today
|
Updated PRD ObjectiveImage annotation is useful for generating training data for machine learning projects. Companies/Teams employ resources internally or work with external vendors to annotate values from documents or images. Our image annotation widget can be used to annotate images by app viewers to generate training data. Success Metrics *
Requirements
Out of Scope
Developer Handoff Document in Figma |
@somangshu Why is there a "Needs Design" label here? |
Needs design was originally added to make this widget consistent with other. Now that we will be starting from the scratch in the future, it might not be required |
Lots of new information here about this widget |
We recently launched our custom widget which allows you to create an image annotator! |
Summary
Users need a widget to annotate images.
A widget that can be used for labelling objects inside images. This is used for ML products.
Features:
Ability to draw inside image using a polygon
Store coordinates of the box and send it an API request
The text was updated successfully, but these errors were encountered: