Use reader client to get operator config map #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operator config map is not always in the same namespace that is being watched, and the client provided by the manager will only read resources in the watched namespace. 'Get' on the configmap will fail in this situation Use the reader client instead, as this will read resources from any namespace
Need to use the same fake client to create and fetch the configmap otherwise, the configmap can't be retrieved
arturdzm
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator config map is not always in the same namespace that is being watched, and the client provided by the manager will only read resources in the watched namespace. 'Get' on the configmap will fail in this situation
Use the reader client instead, as this will read resources from any namespace
fixes #590