Columns and DataType Not Explicitly Set on line 611 of sgraph.py

[CodeSmileBot]

Hello!

I found an AI-Specific Code smell in your project.
The smell is called: Columns and DataType Not Explicitly Set

You can find more information about it in this paper: https://dl.acm.org/doi/abs/10.1145/3522664.3528620.

According to the paper, the smell is described as follows:

Problem	If the columns are not selected explicitly, it is not easy for developers to know what to expect in the downstream data schema. If the datatype is not set explicitly, it may silently continue the next step even though the input is unexpected, which may cause errors later. The same applies to other data importing scenarios.
Solution	It is recommended to set the columns and DataType explicitly in data processing.
Impact	Readability

Example:

### Pandas Column Selection
import pandas as pd
df = pd.read_csv('data.csv')
+ df = df[['col1', 'col2', 'col3']]

### Pandas Set DataType
import pandas as pd
- df = pd.read_csv('data.csv')
+ df = pd.read_csv('data.csv', dtype={'col1': 'str', 'col2': 'int', 'col3': 'float'})

You can find the code related to this smell in this link:

turicreate/src/python/turicreate/data_structures/sgraph.py

Lines 601 to 621 in f57ca7c

	with cython_context():
	sf = SFrame(_proxy=self.__proxy__.get_edges(src_ids, dst_ids, fields))
	if format == "sframe":
	return sf
	if format == "dataframe":
	assert (
	HAS_PANDAS
	), "Cannot use dataframe because Pandas is not available or version is too low."
	if sf.num_rows() == 0:
	return pd.DataFrame()
	else:
	return sf.head(sf.num_rows()).to_dataframe()
	elif format == "list":
	return _dataframe_to_edge_list(sf.to_dataframe())
	else:
	raise ValueError("Invalid format specifier")
	def add_vertices(self, vertices, vid_field=None):
	"""
	Add vertices to the SGraph. Vertices should be input as a list of

.

I also found instances of this smell in other files, such as:

File: https://github.com/apple/turicreate/blob/master/src/external/xgboost/python-package/xgboost/training.py#L343-L353 Line: 348
.

I hope this information is helpful!