Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message for missing "openapi" key clearer. #678

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

deirdresmtoo
Copy link
Contributor

Accidentally hit this error message due to a copy/paste oops and found the resulting error message confusing.

Motivation

Initially when I saw the message, I thought of key as in public/private keys, not key as in key/value pair.

Modifications

Slight change in wording to make it clearer that a key with the name openapi is what's missing.

Result

Error message will be updated.

Test Plan

Updated test results also and verified tests pass.

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, thank you!

@czechboy0 czechboy0 enabled auto-merge (squash) November 22, 2024 06:06
@czechboy0 czechboy0 merged commit 31fa50a into apple:main Nov 22, 2024
34 checks passed
@czechboy0 czechboy0 added the semver/patch No public API change. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants