Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should recordInterval live in CoreMetrics? #92

Open
ktoso opened this issue Mar 18, 2021 · 1 comment
Open

Should recordInterval live in CoreMetrics? #92

ktoso opened this issue Mar 18, 2021 · 1 comment

Comments

@ktoso
Copy link
Member

ktoso commented Mar 18, 2021

I initially said in review that it should be in Metrics: #83

but maybe that was wrong; it does not depend on foundation but just dispatch hm.

func recordInterval(since: DispatchTime, end: DispatchTime = .now()) {
self.recordNanoseconds(end.uptimeNanoseconds - since.uptimeNanoseconds)
}

FYI @tomerd @slashmo

@tomerd
Copy link
Member

tomerd commented Mar 18, 2021

I think depending on Dispatch in Core is fine, there are a couple of other ones in there that can move too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants