Can one of the admins verify this patch?

also note the interesting work the perfect folks did in https://github.com/PerfectlySoft/Perfect-SysInfo

heya @MrLotU, is this ready for review?

Yup. Have a couple of outstanding questions, but I think we're in a good place 😄

@tomerd Any update on this? It's been stale for quite a while 😄

Hi @MrLotU thank you for your patience with this. @drexin @ktoso and myself have been debating how to best integrate this work - if it belongs as part of the swift-metrics repo or an extension to it. At this time, we feel it would best if we did not include this in the swift-metrics repo so it remains focused on the API and not collection or aggregation of metrics. Instead, we think we should create and move this code to a separate repo that provides additional metrics functionality. We recognize this means we need to change the integration again since it is using internal APIs that we would potentially need to expose for extensibility.

WDYT about the approach? a good next step could be to extract this to a separate module within swift-metrics and see what the integration could look like. That should give us an indication as to the final shape APIs changes needed in swift-metrics. If you prefer, I am happy to spend time adding some commits on top of this PR to that end.

No problem at all. I can see your points for moving this into a separate project and agree this would be a great way to move forward.

I will hopefully have some time over the coming weekend to get a first draft up as a new module within swift-metrics to get an idea of what public API is needed 👍

Took me a bit longer to find the time, but I've migrated all of SystemMetrics to a new module.

The only change I made to the CoreMetrics module is making the lock public and making withWriterLock public. However this might not be required if SystemMetrics would ship with it's own lock implementation.

All other functionality & API stays the same

thanks @MrLotU, how about instead of making the Lock public we expose withWriterLock and withReaderLockon the metrics directly? this will help not leak the Lock type which we prefer to keep internal. Then we can call self.withWriterLock instead of self.lock.withWriterLock etc?

That'd be a workable solution 👍 Will implement

Awesome work @MrLotU -- giving it a final review round then and let's find it a home... :)

Thank you very much @MrLotU!

This is now released as part of the new swift metrics extras package! 🎉 🎉 🎉

Closing the PR here then, Thanks again!

thank you @MrLotU

Thanks @tomerd and @ktoso for the continued help & guidance. Super happy with how this turned out 😄