Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider changing Timer, Counter, Gauge and Recorder to a value type. #101

Open
avolokhov opened this issue Sep 3, 2021 · 0 comments
Open

Comments

@avolokhov
Copy link

Currently Timer, Counter, Gauge and Recorder are immutable and don't serve as a storage for corresponding timer/counter etc. data. They serve only as a bridge to an actual <metricType>Handler classes.
Actual backends are only holding a registry of underlying -Handler and public API types are only stored in a user code. This likely means that in the usual use case Timer and counterparts won't be passed around a lot, and changing them to a value type will reduce allocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant